Rushikesh Bathe via Mailman-Developers writes:

 > I was looking into the `_get_preferences()` behavior in
 > `UserMailmanSettingsView` and noticed that it saves preferences
 > during a GET request.  Because of this, just visiting the page
 > converts "unset" preferences into explicitly set ones, which breaks
 > the inheritance behavior.

 > With this change, visiting the page doesn’t modify data, and saving
 > from the form still works as expected.Does this approach look
 > correct? If yes, I can open a merge request.

Please open the merge request.  I think this is correct but I don't
have time to review today.  The MR will help in that.

Steve


-- 
GNU Mailman consultant (installation, migration, customization)
Sirius Open Source    https://www.siriusopensource.com/
Software systems consulting in Europe, North America, and Japan
_______________________________________________
Mailman-Developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/mailman-developers.python.org/
Mailman FAQ: https://wiki.list.org/x/AgA3

Security Policy: https://wiki.list.org/x/QIA9

Reply via email to