On 10/15/2015 3:07 PM, Mark Sapiro wrote:
On 10/15/2015 02:37 PM, Chris Nulk wrote:The question now is if I change the following in Mailman/MailList.py def GetBannedPattern(self, email): """Returns matched entry in ban_list if email matches. Otherwise returns None.
Am I on the correct path?
Yes.
Great. Thank you for the help.
Okay. I have made a number of code changes to 2.1.9 and several of the dropped out/were not needed when we went to 2.1.18-1. There still are a number of changes that keep us from switching without taking a close look at needs to be done. I have recorded all the changes I have made, the problem is finding the time to work on it.Mark, if you have the time and/or inclination, could you explain your comments about Allowing @list_name in ban_list is a simple code modification if you don't care if various 'error' log messages such as list references itself or references non-existent list refer to 'subscribe_auto_approval' even if the error is in ban_list.In Mailman 2.1.19 much of the code in the GetBannedPattern() method was moved to a new GetPattern() method which optionally supports the @listname convention.
Thank you for the information though.
This was done for subscribe_auto_approval, and while it's kind of kludgy, the error log messages that you have above for 'Ban_list listfor %s references own list' and 'Ban_list for list %s references non-existent list %s' refer to subscribe_auto_approval rather than ban_list or something variable. Thus if you had 2.1.19 or later, the code change is much simpler if you don't mind the error log messages saying subscribe_auto_approval when they might mean ban_list.
Okay. That makes sense. Thanks again for the help. Chris ------------------------------------------------------ Mailman-Users mailing list [email protected] https://mail.python.org/mailman/listinfo/mailman-users Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: http://wiki.list.org/x/QIA9 Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-users/archive%40jab.org
