On Wed, Sep 07, 2016 at 10:21:38PM +0530, Pranith Kumar Karampuri wrote:
> >
> > These massive changes +1500 lines of code, have not one test. Eventhough
> > a new volume option is introduced. I really do hope there is some test
> > in the master branch that runs soemthing useful with the new option
> > enabled. Could you please backport that test-case too?
> >
>
> These patches are stabilization of experimental feature compound-fops for
> 3.8.x that is why you see massive changes because it is still stabilizing.
> As per the guidelines it is okay to do this. As this is performance
> enhancement, the nature of tests we did were manual and comparing the time
> elapsed with and without the fixes. We see 10% performance improvement
> overall in small file create workload where the write workload is 40% where
> the enhancement comes into picture. That is the reason you don't see any
> automated test as I don't think we can reliably test the performance
> improvement at the moment in automation. May be we can integrate it with
> the one Nigel & Shyam are driving once it is available.

The performance testing that Shyam and I are driving will not help test these
sort of scenarios. We do not have enough machines to run performance tests that
are this fine-grained.

--
nigelb
_______________________________________________
maintainers mailing list
maintainers@gluster.org
http://www.gluster.org/mailman/listinfo/maintainers

Reply via email to