On 03/03/2017 03:03 PM, Niels de Vos wrote:
On Fri, Mar 03, 2017 at 10:56:38AM -0500, Shyam wrote:
On 03/01/2017 05:22 PM, Niels de Vos wrote:
On Wed, Mar 01, 2017 at 02:43:44PM -0500, Shyam wrote:
Hi,
We do not accept github PRs as our work flow is gerrit based.
To educate contributors, one of the things we could do is to put up a
template as in [1] for the PULL_REQUEST_TEMPLATE. It will look like this [2]
when users attempt to submit PRs.
An alternate idea suggested by Nigel was to accept PRs, but use a Jenkins
job to auto close the same, with some generic (or very specific)
instructions on how to submit it to our gerrit instance.
The advantage of the latter method is that we do not lose the code change
suggested, and we can still evaluate the same and reach out to the
contributor and also possibly get the change into our gerrit instance.
The latter approach looks good, wanted to run this by other maintainers for
their thoughts.
How many PR's do we get? If it is 'a lot', then the time to invest in
the 2nd approach would be ok, otherwise a simple template is probably
sufficient (and Nigel can spend his time on more urgent tasks).
We do not get many PRs.
There is no urgency hence to do this, but doing the latter, give us the
advantage of not losing the proposed code, and will be nicer to contributors
coming in via github.
I will let Nigel comment about his time, as I have clarified (my) priorities
here.
What about the thought itself, does it merit that we post it as a request to
the infra team? I am not hearing otherwise, and I sure think it is useful.
The approach is definitely useful. I think other projects apply this
already too, so it should be possible to use existing scripts for it.
Thank you all, I am raising an infra bug for the same.
Niels
Niels
Thanks,
Shyam
[1] PR template:
https://review.gluster.org/#/c/16618/1/.github/PULL_REQUEST_TEMPLATE
[2] How a PR template appears to contributors:
https://goo.gl/photos/xxc8j3myqzD9tME98
_______________________________________________
maintainers mailing list
[email protected]
http://lists.gluster.org/mailman/listinfo/maintainers
_______________________________________________
maintainers mailing list
[email protected]
http://lists.gluster.org/mailman/listinfo/maintainers
