I already did. You'll notice I sent the second patchset :) On Thu, Sep 13, 2018 at 10:01 PM Atin Mukherjee <[email protected]> wrote:
> Nigel - please apply > https://review.gluster.org/#/c/glusterfs/+/21126/2 to get this corrected. > > On Thu, 13 Sep 2018 at 13:28, Amar Tumballi <[email protected]> wrote: > >> This looks to be an issue with clang-format changes... >> >> On Wed 12 Sep, 2018, 7:58 PM , <[email protected]> wrote: >> >>> See < >>> https://build.gluster.org/job/regression-test-with-multiplex/857/display/redirect?page=changes >>> > >>> >>> Changes: >>> >>> [Vijay Bellur] doc: add coding-standard and commit-msg link in README >>> >>> [Amar Tumballi] dht: Use snprintf instead of strncpy >>> >>> [Amar Tumballi] doc: make developer-index.md as README >>> >>> [Nigel Babu] clang-format: add the config file >>> >>> [Nigel Babu] Land clang-format changes >>> >>> [Nigel Babu] Land part 2 of clang-format changes >>> >>> [Amar Tumballi] template files: revert clang >>> >>> ------------------------------------------ >>> [...truncated 188.30 KB...] >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> Making install in utime >>> Making install in src >>> /usr/bin/python2 < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/features/utime/src/utime-gen-fops-h.py> >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/features/utime/src/utime-autogen-fops-tmpl.h> >>> > utime-autogen-fops.h >>> make --no-print-directory install-am >>> CC utime-helpers.lo >>> CC utime.lo >>> /usr/bin/python2 < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/features/utime/src/utime-gen-fops-c.py> >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/features/utime/src/utime-autogen-fops-tmpl.c> >>> > utime-autogen-fops.c >>> CC utime-autogen-fops.lo >>> CCLD utime.la >>> make[6]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p '/build/install/lib/glusterfs/4.2dev/xlator/features' >>> /bin/sh ../../../../libtool --mode=install /usr/bin/install -c >>> utime.la '/build/install/lib/glusterfs/4.2dev/xlator/features' >>> libtool: install: warning: relinking `utime.la' >>> libtool: install: (cd /build/scratch/xlators/features/utime/src; /bin/sh >>> /build/scratch/libtool --silent --tag CC --mode=relink gcc -Wall -g -O2 -g >>> -rdynamic -O0 -DDEBUG -Wformat -Werror=format-security >>> -Werror=implicit-function-declaration -Wall -Werror -Wno-cpp -module >>> -avoid-version -export-symbols < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/xlator.sym> >>> -Wl,--no-undefined -o utime.la -rpath >>> /build/install/lib/glusterfs/4.2dev/xlator/features utime-helpers.lo >>> utime.lo utime-autogen-fops.lo ../../../../libglusterfs/src/ >>> libglusterfs.la -lrt -ldl -lpthread -lcrypto ) >>> libtool: install: /usr/bin/install -c .libs/utime.soT >>> /build/install/lib/glusterfs/4.2dev/xlator/features/utime.so >>> libtool: install: /usr/bin/install -c .libs/utime.lai >>> /build/install/lib/glusterfs/4.2dev/xlator/features/utime.la >>> libtool: finish: >>> PATH="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/local/bin:/usr/bin:/build/install/sbin:/build/install/bin:/build/install/sbin:/build/install/bin:/sbin" >>> ldconfig -n /build/install/lib/glusterfs/4.2dev/xlator/features >>> ---------------------------------------------------------------------- >>> Libraries have been installed in: >>> /build/install/lib/glusterfs/4.2dev/xlator/features >>> >>> If you ever happen to want to link against installed libraries >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> make[4]: Nothing to be done for `install-exec-am'. >>> make[4]: Nothing to be done for `install-data-am'. >>> Making install in encryption >>> Making install in rot-13 >>> Making install in src >>> CC rot-13.lo >>> CCLD rot-13.la >>> make[5]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p >>> '/build/install/lib/glusterfs/4.2dev/xlator/encryption' >>> /bin/sh ../../../../libtool --mode=install /usr/bin/install -c >>> rot-13.la '/build/install/lib/glusterfs/4.2dev/xlator/encryption' >>> libtool: install: warning: relinking `rot-13.la' >>> libtool: install: (cd /build/scratch/xlators/encryption/rot-13/src; >>> /bin/sh /build/scratch/libtool --silent --tag CC --mode=relink gcc -Wall >>> -g -O2 -g -rdynamic -O0 -DDEBUG -Wformat -Werror=format-security >>> -Werror=implicit-function-declaration -Wall -Werror -Wno-cpp -module >>> -avoid-version -export-symbols < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/xlator.sym> >>> -Wl,--no-undefined -o rot-13.la -rpath >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption rot-13.lo >>> ../../../../libglusterfs/src/libglusterfs.la -lrt -ldl -lpthread >>> -lcrypto ) >>> libtool: install: /usr/bin/install -c .libs/rot-13.soT >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption/rot-13.so >>> libtool: install: /usr/bin/install -c .libs/rot-13.lai >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption/rot-13.la >>> libtool: finish: >>> PATH="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/local/bin:/usr/bin:/build/install/sbin:/build/install/bin:/build/install/sbin:/build/install/bin:/sbin" >>> ldconfig -n /build/install/lib/glusterfs/4.2dev/xlator/encryption >>> ---------------------------------------------------------------------- >>> Libraries have been installed in: >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption >>> >>> If you ever happen to want to link against installed libraries >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> Making install in crypt >>> Making install in src >>> CC keys.lo >>> CC data.lo >>> CC metadata.lo >>> CC atom.lo >>> CC crypt.lo >>> CCLD crypt.la >>> make[5]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p >>> '/build/install/lib/glusterfs/4.2dev/xlator/encryption' >>> /bin/sh ../../../../libtool --mode=install /usr/bin/install -c >>> crypt.la '/build/install/lib/glusterfs/4.2dev/xlator/encryption' >>> libtool: install: warning: relinking `crypt.la' >>> libtool: install: (cd /build/scratch/xlators/encryption/crypt/src; >>> /bin/sh /build/scratch/libtool --silent --tag CC --mode=relink gcc -Wall >>> -g -O2 -g -rdynamic -O0 -DDEBUG -Wformat -Werror=format-security >>> -Werror=implicit-function-declaration -Wall -Werror -Wno-cpp -module >>> -avoid-version -export-symbols < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/xlator.sym> >>> -Wl,--no-undefined -o crypt.la -rpath >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption keys.lo data.lo >>> metadata.lo atom.lo crypt.lo ../../../../libglusterfs/src/ >>> libglusterfs.la -lssl -lcrypto -lrt -ldl -lpthread -lcrypto ) >>> libtool: install: /usr/bin/install -c .libs/crypt.soT >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption/crypt.so >>> libtool: install: /usr/bin/install -c .libs/crypt.lai >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption/crypt.la >>> libtool: finish: >>> PATH="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/local/bin:/usr/bin:/build/install/sbin:/build/install/bin:/build/install/sbin:/build/install/bin:/sbin" >>> ldconfig -n /build/install/lib/glusterfs/4.2dev/xlator/encryption >>> ---------------------------------------------------------------------- >>> Libraries have been installed in: >>> /build/install/lib/glusterfs/4.2dev/xlator/encryption >>> >>> If you ever happen to want to link against installed libraries >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> make[4]: Nothing to be done for `install-exec-am'. >>> make[4]: Nothing to be done for `install-data-am'. >>> Making install in mount >>> Making install in fuse >>> Making install in src >>> CC fuse-helpers.lo >>> CC fuse-resolve.lo >>> CC fuse-bridge.lo >>> CC misc.lo >>> CC mount.lo >>> CC mount-common.lo >>> CCLD fuse.la >>> make[5]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p '/build/install/lib/glusterfs/4.2dev/xlator/mount' >>> /bin/sh ../../../../libtool --mode=install /usr/bin/install -c >>> fuse.la '/build/install/lib/glusterfs/4.2dev/xlator/mount' >>> libtool: install: warning: relinking `fuse.la' >>> libtool: install: (cd /build/scratch/xlators/mount/fuse/src; /bin/sh >>> /build/scratch/libtool --silent --tag CC --mode=relink gcc -Wall -g -O2 -g >>> -rdynamic -O0 -DDEBUG -Wformat -Werror=format-security >>> -Werror=implicit-function-declaration -Wall -Werror -Wno-cpp -module >>> -avoid-version -export-symbols < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/xlator.sym> >>> -Wl,--no-undefined -o fuse.la -rpath >>> /build/install/lib/glusterfs/4.2dev/xlator/mount fuse-helpers.lo >>> fuse-resolve.lo fuse-bridge.lo misc.lo mount.lo mount-common.lo >>> ../../../../libglusterfs/src/libglusterfs.la -lm -lrt -ldl -lpthread >>> -lcrypto ) >>> libtool: install: /usr/bin/install -c .libs/fuse.soT >>> /build/install/lib/glusterfs/4.2dev/xlator/mount/fuse.so >>> libtool: install: /usr/bin/install -c .libs/fuse.lai >>> /build/install/lib/glusterfs/4.2dev/xlator/mount/fuse.la >>> libtool: finish: >>> PATH="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/local/bin:/usr/bin:/build/install/sbin:/build/install/bin:/build/install/sbin:/build/install/bin:/sbin" >>> ldconfig -n /build/install/lib/glusterfs/4.2dev/xlator/mount >>> ---------------------------------------------------------------------- >>> Libraries have been installed in: >>> /build/install/lib/glusterfs/4.2dev/xlator/mount >>> >>> If you ever happen to want to link against installed libraries >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> Making install in utils >>> make[5]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p '/build/install/sbin' >>> /usr/bin/install -c mount.glusterfs '/build/install/sbin' >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> make[4]: Nothing to be done for `install-exec-am'. >>> make[4]: Nothing to be done for `install-data-am'. >>> Making install in nfs >>> Making install in server >>> Making install in src >>> CC nfs.lo >>> CC nfs-common.lo >>> CC nfs-fops.lo >>> CC nfs-inodes.lo >>> CC nfs-generics.lo >>> CC mount3.lo >>> CC nfs3-fh.lo >>> CC nfs3.lo >>> CC nfs3-helpers.lo >>> CC nlm4.lo >>> CC nlmcbk_svc.lo >>> CC mount3udp_svc.lo >>> CC acl3.lo >>> CC netgroups.lo >>> CC exports.lo >>> CC mount3-auth.lo >>> CC auth-cache.lo >>> CCLD server.la >>> make[5]: Nothing to be done for `install-exec-am'. >>> /usr/bin/mkdir -p '/build/install/lib/glusterfs/4.2dev/xlator/nfs' >>> /bin/sh ../../../../libtool --mode=install /usr/bin/install -c >>> server.la '/build/install/lib/glusterfs/4.2dev/xlator/nfs' >>> libtool: install: warning: relinking `server.la' >>> libtool: install: (cd /build/scratch/xlators/nfs/server/src; /bin/sh >>> /build/scratch/libtool --silent --tag CC --mode=relink gcc -Wall -g -O2 -g >>> -rdynamic -O0 -DDEBUG -Wformat -Werror=format-security >>> -Werror=implicit-function-declaration -Wall -Werror -Wno-cpp -module >>> -avoid-version -export-symbols < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/nfs/server/src/nfsserver.sym> >>> -Wl,--no-undefined -o server.la -rpath >>> /build/install/lib/glusterfs/4.2dev/xlator/nfs nfs.lo nfs-common.lo >>> nfs-fops.lo nfs-inodes.lo nfs-generics.lo mount3.lo nfs3-fh.lo nfs3.lo >>> nfs3-helpers.lo nlm4.lo nlmcbk_svc.lo mount3udp_svc.lo acl3.lo netgroups.lo >>> exports.lo mount3-auth.lo auth-cache.lo ../../../../libglusterfs/src/ >>> libglusterfs.la ../../../../api/src/libgfapi.la -lrt -ldl -lpthread >>> -lcrypto ) >>> libtool: install: /usr/bin/install -c .libs/server.soT >>> /build/install/lib/glusterfs/4.2dev/xlator/nfs/server.so >>> libtool: install: /usr/bin/install -c .libs/server.lai >>> /build/install/lib/glusterfs/4.2dev/xlator/nfs/server.la >>> libtool: finish: >>> PATH="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin:/usr/local/bin:/usr/bin:/build/install/sbin:/build/install/bin:/build/install/sbin:/build/install/bin:/sbin" >>> ldconfig -n /build/install/lib/glusterfs/4.2dev/xlator/nfs >>> ---------------------------------------------------------------------- >>> Libraries have been installed in: >>> /build/install/lib/glusterfs/4.2dev/xlator/nfs >>> >>> If you ever happen to want to link against installed libraries >>> in a given directory, LIBDIR, you must either use libtool, and >>> specify the full pathname of the library, or use the `-LLIBDIR' >>> flag during linking and do at least one of the following: >>> - add LIBDIR to the `LD_LIBRARY_PATH' environment variable >>> during execution >>> - add LIBDIR to the `LD_RUN_PATH' environment variable >>> during linking >>> - use the `-Wl,-rpath -Wl,LIBDIR' linker flag >>> - have your system administrator add LIBDIR to `/etc/ld.so.conf' >>> >>> See any operating system documentation about shared libraries for >>> more information, such as the ld(1) and ld.so(8) manual pages. >>> ---------------------------------------------------------------------- >>> make[5]: Nothing to be done for `install-exec-am'. >>> make[5]: Nothing to be done for `install-data-am'. >>> make[4]: Nothing to be done for `install-exec-am'. >>> make[4]: Nothing to be done for `install-data-am'. >>> Making install in mgmt >>> Making install in glusterd >>> Making install in src >>> CC glusterd_la-glusterd.lo >>> CC glusterd_la-glusterd-handler.lo >>> CC glusterd_la-glusterd-sm.lo >>> CC glusterd_la-glusterd-op-sm.lo >>> CC glusterd_la-glusterd-utils.lo >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/mgmt/glusterd/src/glusterd-utils.c>: >>> In function 'is_brick_mx_enabled': >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/mgmt/glusterd/src/glusterd-utils.c>:115:1: >>> error: expected expression before '<<' token >>> <<<<<<< HEAD >>> ^ >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/mgmt/glusterd/src/glusterd-utils.c>:117:1: >>> error: expected expression before '==' token >>> ======= >>> ^ >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/mgmt/glusterd/src/glusterd-utils.c>:119:1: >>> error: expected expression before '>>' token >>> >>>>>>> a1a24dca487ee6046e5da57ae39b7ff4a73b817c >>> ^ >>> < >>> https://build.gluster.org/job/regression-test-with-multiplex/ws/xlators/mgmt/glusterd/src/glusterd-utils.c>:120:1: >>> error: control reaches end of non-void function [-Werror=return-type] >>> } >>> ^ >>> cc1: all warnings being treated as errors >>> make[4]: *** [glusterd_la-glusterd-utils.lo] Error 1 >>> make[4]: *** Waiting for unfinished jobs.... >>> make[3]: *** [install-recursive] Error 1 >>> make[2]: *** [install-recursive] Error 1 >>> make[1]: *** [install-recursive] Error 1 >>> make: *** [install-recursive] Error 1 >>> Build step 'Execute shell' marked build as failure >>> _______________________________________________ >>> maintainers mailing list >>> [email protected] >>> https://lists.gluster.org/mailman/listinfo/maintainers >>> >> _______________________________________________ >> maintainers mailing list >> [email protected] >> https://lists.gluster.org/mailman/listinfo/maintainers >> > -- > - Atin (atinm) > -- nigelb
_______________________________________________ maintainers mailing list [email protected] https://lists.gluster.org/mailman/listinfo/maintainers
