Hi
I have added the following patch to prevent from have case where
dependencies are missing in the files which are generated automatically.
With this patch chechkpg is failing. This sounds better to me, since
there is an error at package building time instead of having missing deps.
I was wondering if we should not find a way to go around this.
According to my understandings ... GAR has two different "check".
PREREQUISITE_PKGS and REQUIRED_PKGS. PREREQUISITE_PKGS are used to check
requirement for build, and are used before building the package, and
REQUIRED_PKGS are used to generate automatically depend files. Then
after building the package, checkpkg make some controls, including the
validity of information in the depend file.
Current situation is that we cannot specify a package in the depend file
if is not installed on the machine.
I think it may be interesting to have a way to make dependencies against
packages which are not installed if these package are not used for
compilation. A typical case is java libs. I think the same kind of need
may exist for php stuff (packages not requiring a compilation stage like
C/C++ software may have).
Any thought about this ?
Cheers
W.
--
William http://www.wbonnet.net
http://www.sunwizard.net Le site français des amateurs de stations Unix
http://www.opencsw.org Community SoftWare for Solaris
http://www.guses.org French speaking Solaris User Group
--- Begin Message ---
Revision: 3630
http://gar.svn.sourceforge.net/gar/?rev=3630&view=rev
Author: wbonnet
Date: 2009-03-08 14:18:12 +0000 (Sun, 08 Mar 2009)
Log Message:
-----------
Fix : If a pkg is not installed and declared in the REQUIRED lists, nothing was
output to generaetd depend file, and target bilding was not stopped. This could
create missing dependencies.
This patch add the given package in the depend name without its description.
Modified Paths:
--------------
csw/mgar/gar/v2/gar.pkg.mk
Modified: csw/mgar/gar/v2/gar.pkg.mk
===================================================================
--- csw/mgar/gar/v2/gar.pkg.mk 2009-03-08 12:09:28 UTC (rev 3629)
+++ csw/mgar/gar/v2/gar.pkg.mk 2009-03-08 14:18:12 UTC (rev 3630)
@@ -282,7 +282,7 @@
$(foreach PKG,$(_EXTRA_GAR_PKGS) $(REQUIRED_PKGS_$*)
$(REQUIRED_PKGS),\
$(if $(SPKG_DESC_$(PKG)), \
echo "P $(PKG) $(call catalogname,$(PKG)) -
$(SPKG_DESC_$(PKG))";, \
- echo "$(shell /usr/bin/pkginfo $(PKG) | awk '{
$$1 = "P"; print } ')"; \
+ echo "$(shell /usr/bin/pkginfo $(PKG) || echo
"P $(PKG) - " | awk '{ $$1 = "P"; print } ')"; \
) \
)) >$@)
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
devel mailing list
[email protected]
https://lists.opencsw.org/mailman/listinfo/devel
--- End Message ---
_______________________________________________
maintainers mailing list
[email protected]
https://lists.opencsw.org/mailman/listinfo/maintainers
