On 05/18/2009 04:45 PM, Dagobert Michelsen wrote:
Hi John,
Am 18.05.2009 um 21:28 schrieb John Ellson:
There is a new package:
"gts: GNU Triangulated Surface Library"
now available in testing.
This is my first package. It was built with mgar, so a review of
my mgar/pkg/gts/ tree in svn would also be appreciated.
Some suggestions:
- Please use for SourceForge
MASTER_SITES = $(SF_MIRRORS)
For several big sites the URLs have been stored centrally.
- For SourceForge the upstream watch works slightly different due to the
structure of the download page. Please use
UPSTREAM_MASTER_SITES = $(SF_PROJECT_SHOWFILE)=66612 (change to
your id)
UPSTREAM_USE_SF = 1
- You are using a static depend CSWgts.depend and dynamic depends with
REQUIRED_PKGS. They both serve the same purpose and defining both
will ignore REQUIRED_PKGS. Please remove CSWgts.depend and the notion
of it in DISTFILES.
- You are using a static gspec file CSWgts.gspec. As the bitname and
pkgname
are the same as the GARNAME the defaults will be fine. You can safely
remove the gspec-file and the notion of it in DISTFILES without change
in behaviour. Static gspec files are also old-style and the newer
variants from
<http://apps.sourceforge.net/trac/gar/wiki/DynamicPackageFiles>
should be used wherever possible.
- .la-files are already excluded during merge by default. See
<http://apps.sourceforge.net/trac/gar/browser/csw/mgar/gar/v2/gar.mk#L549>
for details
- The NO_ISAEXEC line is only important when you build multiple ISAs
(like the commented out 64 bit ISA with BUILD64=1). When building only
one ISA it does nothing.
These are a lot of comments. Please take them as result of the, umh,
imperfect
documentation. Which documentation have you missed most on your path?
What can I do to improve your getting started experience with GAR?
OK, Got those. New gts packages posted to /home/testing.
I'll work on some notes about GAR for you....
John
_______________________________________________
maintainers mailing list
[email protected]
https://lists.opencsw.org/mailman/listinfo/maintainers
