On Tue, Nov 17, 2009 at 5:12 PM, Philip Brown <[email protected]> wrote: >>(Dagobert writes) >> I had this problem myself some times but didn't recognize the cause >> properly: >> grep filter-out */trunk/Makefile | grep CFLAGS >> I even used argument-reordering on compile invocation for flac to >> work around it which may have better be solved in the above way. >> Now that I have understood it I would propose to remove >> the "-I" from CFLAGS in GAR, but I am afraid that this may break >> existing Makefiles as they may rely on it. This is especially true >> for manual builds which pass CFLAGS explicitly without passing >> CPPFLAGS explicitly. >> >> What do the C-gurus say? James? Anybody? >> > > > In my opinion, it belongs in CPPFLAGS, if you are going to force defaults.
Yes, CPPFLAGS are for the C PreProcessor, and it's the preprocessor that takes care of including files. References: http://stackoverflow.com/questions/495598/difference-between-cppflags-and-cxxflags-in-gnu-make http://en.wikipedia.org/wiki/CPPFLAGS > (and you should make sure to force our default as "first" :-) > > package builds that break, will break. Although most shouldnt. > Ones that do, will have to be fixed when needed. I second that. It's worth the trouble. If there's a build that needs includes to be passed via CFLAGS, it's not hard to add them by hand in the Makefile. Maciej _______________________________________________ maintainers mailing list [email protected] https://lists.opencsw.org/mailman/listinfo/maintainers
