> From: "Christian Jullien" <[email protected]> > Cc: <[email protected]> > Date: Wed, 22 Jan 2020 20:57:37 +0100 > > Ok here are the patches:
Thanks. A few questions and comments below. > :: Find a compiler. Visual Studio requires a lot of effort to locate :-/. > %COMPILER% >nul 2>&1 > @@ -172,6 +182,7 @@ > set OUTDIR=.\GccRel > set LNKOUT=./GccRel > set OPTS=-O2 > +set DIRENT=N What is this part about? Is it needed, and if so, why? > +:TccCompile > +:: TCC Compile > +echo on > +%COMPILER% -mthreads -Wall -std=c11 %OPTS% -I%OUTDIR%/src -I./src Why are you using -std=c11 here? this is unlike all the other compilations, which use C99. > +:TccLink > +:: TCC Link > +echo on > +echo %GUILELIBS% -lkernel32 -luser32 -lgdi32 -lcomdlg32 -ladvapi32 > -lshell32 -lole32 -loleaut32 -lodbc32 -lodbccp32 >>%OUTDIR%\link.sc > +%COMPILER% -mthreads %OPTS% -o %LNKOUT%/%MAKE%.exe @%LNKOUT%/link.sc Does this build the import library? And in general, does the tcc build support loadable modules? Last, but not least: a contribution this large will need you to sign legal papers assigning the copyright to the FSF. Would you like me to send you the form to fill to start the legal paperwork? Paul, any comments? The changes look reasonable to me, FWIW.
