> So here I am ripping all the htmlifypods code out of MakeMaker and I
> come upon this:
> #
> # When we eval a Makefile.PL in a subdirectory, that one will ask
> # us (the parent) for the values and will prepend "..", so that
> # all files to be installed end up below OUR ./blib
> #
> %Prepend_dot_dot =
> qw(
> INST_BIN 1 INST_EXE 1 INST_LIB 1 INST_ARCHLIB 1 INST_SCRIPT 1
> MAP_TARGET 1 INST_MAN1DIR 1 INST_MAN3DIR 1 PERL_SRC 1
> PERL 1 FULLPERL 1
> );
> why its written in this clumsy way, I dunno. Maybe at one point there
> were different values for each key.
Nope, that was plain silliness.
> I'd rewrite it like this:
> %Prepend_dot_dot = map {($_ => 1)}, qw(INST_BIN INST_EXE ...);
> But that's not what makes it interesting. %Prepend_dot_dot is defined
> at the end of ExtUtils::MakeMaker->full_setup. Its a global and its
> hard-coded. The only place its used is in ExtUtils::MakeMaker->new
> (maybe it was used in other placed before). So there's really no more
> reason for it to be a global. Yay! One less global.
Good. It was indeed used in some other places in MakeMaker 4.xx which
were phased out later.
BTW, I'd say constant globals are OK, it's globals used for variables
that are a pain.
> Finally, if we look at where its used we see:
> for $key (keys %Prepend_dot_dot) {
> and that's the only reference to it. So... we have awkward code to
> make a hash which we then flatten into an array.
> In the end, we're left with a simple array declaration.
> @Prepend_dot_dot = qw(
> INST_BIN INST_EXE INST_LIB INST_ARCHLIB INST_SCRIPT
> MAP_TARGET INST_MAN1DIR INST_MAN3DIR PERL_SRC
> PERL FULLPERL
> );
> and a simple foreach loop:
> for my $path (@Prepend_dot_dot) {
> I'm leaving it global since I haven't quite decided what to do about
> breaking up full_setup() and its not a priority.
Full_setup() was only there to speed up some simple uses of MakeMaker.
> And MakeMaker is nudged another inch closer to sanity.
Applause!
> PS I'm planning on doing a talk about all this, so I'm sort of using
> this list as a running notebook. I'm also hoping other people will
> join in the fun and start fixing these anachronisms along with me.
I have a couple of historical MM versions, do you want them?
../MM-v1-3:
total 232
-rw-r--r-- 1 k k 5838 Jun 5 1995 MakeMaker.pm.1994-09-19.gz
-rw-r--r-- 1 k k 6742 Jun 5 1995 MakeMaker.pm.1994-09-24.gz
-rw-r--r-- 1 k k 7117 Jun 5 1995 MakeMaker.pm.1994-10-12.gz
-rw-r--r-- 1 k k 9171 Jun 5 1995 MakeMaker.pm.1994-10-31.gz
-rw-r--r-- 1 k k 11833 Jun 5 1995 MakeMaker.pm.3.1.gz
-rw-r--r-- 1 k k 19420 Jun 5 1995 MakeMaker.pm.3.10.gz
-rw-r--r-- 1 k k 19903 Jun 5 1995 MakeMaker.pm.3.11.gz
-rw-r--r-- 1 k k 13499 Jun 5 1995 MakeMaker.pm.3.2.gz
-rw-r--r-- 1 k k 12659 Jun 5 1995 MakeMaker.pm.3.2b.gz
-rw-r--r-- 1 k k 14873 Jun 5 1995 MakeMaker.pm.3.3.gz
-rw-r--r-- 1 k k 16358 Jun 5 1995 MakeMaker.pm.3.4.gz
-rw-r--r-- 1 k k 18291 Jun 5 1995 MakeMaker.pm.3.6.gz
-rw-r--r-- 1 k k 18491 Jun 5 1995 MakeMaker.pm.3.7.gz
-rw-r--r-- 1 k k 18527 Jun 5 1995 MakeMaker.pm.3.8.gz
-rw-r--r-- 1 k k 19242 Jun 5 1995 MakeMaker.pm.3.9.gz
../MM-v4:
total 1168
-rw-r--r-- 1 k k 45450 May 19 1997 MM-4.16-i.e.5.001m.tar.gz
-rw-r--r-- 1 k k 32489 May 10 1995 MakeMaker-4.1.tar.gz
-rw-r--r-- 1 k k 34912 May 19 1995 MakeMaker-4.110.tar.gz
-rw-r--r-- 1 k k 35885 May 28 1995 MakeMaker-4.12.tar.gz
-rw-r--r-- 1 k k 37426 Jun 1 1995 MakeMaker-4.13.tar.gz
-rw-r--r-- 1 k k 37668 Jun 6 1995 MakeMaker-4.14.tar.gz
-r--r--r-- 1 k k 30767 Jun 14 1995 MakeMaker-4.15.pm.gz
-rw-r--r-- 1 k k 41400 Jul 1 1995 MakeMaker-4.17.tar.gz
-rw-r--r-- 1 k k 44284 Aug 7 1995 MakeMaker-4.18.tar.gz
-rw-r--r-- 1 k k 45999 Oct 14 1995 MakeMaker-4.19.tar.gz
-rw------- 1 k k 45196 Oct 15 1995 MakeMaker-4.20.tar.gz
-rw-r--r-- 1 k k 47104 Oct 16 1995 MakeMaker-4.21.tar.gz
-rw-r--r-- 1 k k 48125 Oct 16 1995 MakeMaker-4.22.tar.gz
-rw-r--r-- 1 k k 50485 Oct 20 1995 MakeMaker-4.23.tar.gz
-rw-r--r-- 1 k k 20578 Jun 5 1995 MakeMaker.pm.4.00.gz
-rw-r--r-- 1 k k 20621 Jun 5 1995 MakeMaker.pm.4.01.gz
-rw-r--r-- 1 k k 22060 Jun 5 1995 MakeMaker.pm.4.02.gz
-rw-r--r-- 1 k k 22116 Jun 5 1995 MakeMaker.pm.4.03.gz
-rw-r--r-- 1 k k 24724 Jun 5 1995 MakeMaker.pm.4.04.gz
-rw-r--r-- 1 k k 24630 Jun 5 1995 MakeMaker.pm.4.05.gz
-rw-r--r-- 1 k k 24365 Jun 5 1995 MakeMaker.pm.4.06.gz
-rw-r--r-- 1 k k 24034 Jun 5 1995 MakeMaker.pm.4.061.gz
-rw-r--r-- 1 k k 24281 Jun 5 1995 MakeMaker.pm.4.07.gz
-rw-r--r-- 1 k k 24466 Jun 5 1995 MakeMaker.pm.4.08.gz
-rw-r--r-- 1 k k 24468 Jun 5 1995 MakeMaker.pm.4.081.gz
-rw-r--r-- 1 k k 24505 Jun 5 1995 MakeMaker.pm.4.082.gz
-rw-r--r-- 1 k k 24552 Jun 5 1995 MakeMaker.pm.4.083.gz
-rw-r--r-- 1 k k 24121 Jun 5 1995 MakeMaker.pm.4.084.gz
-rw-r--r-- 1 k k 24437 Jun 5 1995 MakeMaker.pm.4.085.gz
-rw-r--r-- 1 k k 24705 Jun 5 1995 MakeMaker.pm.4.086.gz
-rw-r--r-- 1 k k 26234 Jun 5 1995 MakeMaker.pm.4.09.gz
-rw-r--r-- 1 k k 25664 Jun 5 1995 MakeMaker.pm.4.091.gz
-rw-r--r-- 1 k k 25717 Jun 5 1995 MakeMaker.pm.4.092.gz
-rw-r--r-- 1 k k 27272 Jun 5 1995 MakeMaker.pm.4.093.gz
-rw-r--r-- 1 k k 27273 Jun 5 1995 MakeMaker.pm.4.094.gz
-rw-r--r-- 1 k k 29130 Jun 5 1995 MakeMaker.pm.4.100.gz
../MM-v5:
total 3664
-rw-r--r-- 1 k k 53462 Oct 26 1995 MakeMaker-5.00.tar.gz
-rw-r--r-- 1 k k 54209 Nov 3 1995 MakeMaker-5.01-buggy.tar.gz
-rw-r--r-- 1 k k 54161 Nov 3 1995 MakeMaker-5.01.tar.gz
-rw-r--r-- 1 k k 54718 Nov 4 1995 MakeMaker-5.02.tar.gz
-rw-r--r-- 1 k k 53608 Nov 4 1995 MakeMaker-5.03.tar.gz
-rw-r--r-- 1 k k 54456 Nov 11 1995 MakeMaker-5.04.tar.gz
-rw-r--r-- 1 k k 54488 Nov 12 1995 MakeMaker-5.05.tar.gz
-rw-r--r-- 1 k k 54524 Nov 12 1995 MakeMaker-5.06.tar.gz
-r--r--r-- 1 k k 56095 Nov 21 1995 MakeMaker-5.07.tar.gz
-rw-r--r-- 1 k k 63300 Nov 22 1995 MakeMaker-5.08.tar.gz
-rw-r--r-- 1 k k 63955 Nov 23 1995 MakeMaker-5.09.tar.gz
-rw-r--r-- 1 k k 64141 Nov 24 1995 MakeMaker-5.10.tar.gz
-rw-r--r-- 1 k k 71277 Dec 18 1995
MakeMaker-5.11-in.5002b1f.tar.gz
-rw-r--r-- 1 k k 65975 Dec 5 1995 MakeMaker-5.11.tar.gz
-rw-r--r-- 1 k k 66387 Dec 11 1995 MakeMaker-5.12.tar.gz
-rw-r--r-- 1 k k 82216 Dec 15 1995 MakeMaker-5.13.tar.gz
-rw-r--r-- 1 k k 82398 Dec 16 1995 MakeMaker-5.14.tar.gz
-rw-r--r-- 1 k k 82638 Dec 24 1995 MakeMaker-5.15.tar.gz
-rw-r--r-- 1 k k 84070 Jan 5 1996 MakeMaker-5.16.tar.gz
-rw-r--r-- 1 k k 86929 Jan 22 1996 MakeMaker-5.17.tar.gz
-rw-r--r-- 1 k k 87755 Jan 28 1996 MakeMaker-5.18.tar.gz
-rw-r--r-- 1 k k 89086 Feb 4 1996 MakeMaker-5.19.tar.gz
-rw-r--r-- 1 k k 93039 Feb 6 1996 MakeMaker-5.20.tar.gz
-r--r--r-- 1 k k 93528 Feb 23 1996 MakeMaker-5.21.tar.gz
-rw-r--r-- 1 k k 94752 Feb 20 1996 MakeMaker-5.22.tar.gz
-rw-r----- 1 k k 97665 Feb 25 1996 MakeMaker-5.23.tar.gz
-rw-r--r-- 1 k k 98035 Feb 27 1996 MakeMaker-5.24.tar.gz
-rw-r--r-- 1 k k 100476 Feb 29 1996 MakeMaker-5.25.tar.gz
-rw-r--r-- 1 k k 107735 Apr 4 1996 MakeMaker-5.27.tar.gz
-rw-r--r-- 1 k k 106009 Apr 8 1996 MakeMaker-5.28.tar.gz
-rw-r--r-- 1 k k 106671 Apr 11 1996 MakeMaker-5.29.tar.gz
-rw-r--r-- 1 k k 105227 Apr 11 1996 MakeMaker-5.30.tar.gz
-r--r--r-- 1 k k 105764 May 3 1996 MakeMaker-5.31.tar.gz
-rw-r--r-- 1 k k 107103 May 25 1996 MakeMaker-5.32.tar.gz
-rw-r--r-- 1 k k 107156 Jun 19 1996 MakeMaker-5.33.tar.gz
-rw-r--r-- 1 k k 107883 Sep 3 1996 MakeMaker-5.37.tar.gz
-rw-r--r-- 1 k k 107997 Sep 4 1996 MakeMaker-5.38.tar.gz
-rw-r--r-- 1 k k 87659 Dec 20 1996 MakeMaker-5.39.tar.gz
-rw-r--r-- 1 k k 88226 Feb 11 1997 MakeMaker-5.40.tar.gz
-rw-r--r-- 1 k k 93783 May 19 1997 MakeMaker-5.4002.tar.gz
-rw-r--r-- 1 k k 97368 Jun 28 1997 MakeMaker-5.41.tar.gz
-rw-r--r-- 1 k k 98103 Aug 1 1997 MakeMaker-5.42.tar.gz
--
andreas
