>>>>> On Thu, 18 Apr 2002 23:28:16 -0400, Michael G Schwern <[EMAIL PROTECTED]> said:
> ExtUtils::Manifest docs say:
> skipcheck() lists all the files that are skipped due to your
> C<MANIFEST.SKIP> file.
> but skipcheck() really returns two array refs, one to a list of files
> found and one to files missing. It doesn't list the files skipped due
> to your MANIFEST.SKIP.
For one this is badly written documentation, but it's also a bad
interface idea. It does *list* (on STDERR) the files being skipped,
but it does not return them.
> Even the test questions the interface:
> # I'm not sure why this should be... shouldn't $missing be the only one?
> my ($found, $missing );
> catch_warning( sub {
> ( $found, $missing ) = skipcheck()
> });
> Looking at the code, skipcheck() is just filecheck() except it warns
> when it can't find something.
Maybe I'm dense, but I think, it warns when it skips something that is
there.
> And skipcheck() oddly returns two array
> refs instead of the documented list of what was skipped.
As I said, odd interface design.
> I don't find that useful. So I'm calling this a bug and changing the
> return value of skipcheck() to match the docs.
Thanks.
--
andreas
