Ilya, while adapting the perl_archive() tests to the new init_linker(), I
noticed a test in MM_OS2.t that doesn't look like it could possibly be
passing.

ExtUtils::MM_OS2 says:

  sub perl_archive_after
  {
   return "\$(PERL_INC)/libperl_override\$(LIB_EXT)" unless $OS2::is_aout;
   return "";
  }

MM_OS2.t says:

 {
        my $aout = 0;
        local *OS2::is_aout;
        *OS2::is_aout = \$aout;
        
        isnt( ExtUtils::MM_OS2->perl_archive_after(), '', 
               'perl_archive_after() should return string without $is_aout set');
        $aout = 1;
        is( ExtUtils::MM_OS2->perl_archive_after(), '', 
                '... and blank string if it is set' );
 }

According to that test, perl_archive_after() should never return anything,
but that's obviously a mistake since it contradicts both the code and the
name of the test.

Is this test mysteriously passing or are the tests not being run or the
failure not reported?


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Perl Quality Assurance      <[EMAIL PROTECTED]>         Kwalitee Is Job One
I stared into the Abyss, and it avoided making eye contact.

Reply via email to