On Fri, Dec 12, 2003 at 08:56:27AM +0800, Autrijus Tang wrote:
> This is so people won't need to practice clairvoyancy to foresee new
> MANIFEST.SKIP entries like "^blibdirs$" -- otherwise, Module::Signature
> is rendered broken.
Thanks for the patch, but I can't change existing default behavior. In most
cases people only want to add to the existing MANIFEST.SKIP but in others
they do want to override it.
So this needs some sort of option to indicate that the MANIFEST.SKIP
should add to, not override, the default. Possibly an "#include default"
line in the MANIFEST.SKIP or WriteMakefile() argument.
> --- Manifest.pm.orig Fri Dec 12 08:48:05 2003
> +++ Manifest.pm Fri Dec 12 08:52:41 2003
> @@ -348,14 +348,18 @@
> my @skip ;
> my $mfile = "$MANIFEST.SKIP";
> local(*M,$_);
> - open M, $mfile or open M, $DEFAULT_MSKIP or return sub {0};
> - while (<M>){
> - chomp;
> - next if /^#/;
> - next if /^\s*$/;
> - push @skip, _macify($_);
> + foreach my $M ($mfile, $DEFAULT_MSKIP) {
> + open M, $M or next;
> + while (<M>){
> + chomp;
> + next if /^#/;
> + next if /^\s*$/;
> + push @skip, _macify($_);
> + }
> + close M;
> }
> - close M;
> + return sub {0} unless @skip;
> +
> my $opts = $Is_VMS ? '(?i)' : '';
>
> # Make sure each entry is isolated in its own parentheses, in case
--
Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern/
The easy way is always mined.
