On Sun, Dec 14, 2003 at 01:17:49AM +0100, Marcus Holland-Moritz wrote: > Here's a first shot. The attached patch (against the latest repository > snapshot) adds a 'LICENSE' parameter to MakeMaker. It also tries to make > the metafile output a little more Module::Build-ish. I didn't add a > parameter for 'DISTRIBUTION_TYPE', since this is currently hardcoded > also in M::B. > > As this is my first patch to MM, please let me know if I missed anything.
Looks good at first glance. My only comment would be that it would be nice if the license warning could happen only as the META.yml is generated. This will make MM forward compatible should we add more licenses, so if an older MM installs a module generated with a new license type it won't warn. That'll probably require moving the license check code into an ExtUtils::MM::Command function so the check can be done in the metafile target. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern/ Operation Thrusting Peach
