John Peacock wrote: > Michael G Schwern wrote: >> As that subroutine is only called in one place, its the very first >> thing in WriteMakefile() even before a MakeMaker object is created, I >> can say its fairly impossible to get that from a $VERSION >> declaration. > > I wish you had taken me at my word, rather than try to explain it away: > > What you failed to remember is that not all code that uses > ExtUtil::MakeMaker is code *you* control. > > The patch, to refresh your memory, was trivial:
When it comes to MakeMaker I am very conservative and very skeptical. I don't like to take bug reports and patches without throughly understanding them. You sent a patch about a bug with a single line of code to trigger it. I was unable to replicate that bug and asked for more information. http://www.nntp.perl.org/group/perl.makemaker/2007/02/msg2694.html Furthermore, you said you'd come back with the full bug report. http://www.nntp.perl.org/group/perl.makemaker/2007/02/msg2699.html I never got that report. A user says "When I do A, B happens." By my figuring of the code and testing that's impossible. There must be something missing from the report. Something else is going on. I can't reproduce the problem. I'm waiting for more information from the reporter. You're damn right I'm not going to just apply the patch! Don't get snippy, if I took every patch at its word CPAN would be breaking twice a month. Then I went and dug out an actual case where the warning does happen! http://www.nntp.perl.org/group/perl.makemaker/2007/02/msg2699.html Maybe its not your case, but you didn't give me much to go on. Either way, the problem is acknowledged as a valid one however its getting triggered. I also noted what will have to happen in order for the problem to really be fixed. Your trivial fix is too trivial, I'm sorry, and had to be rejected. I await the slightly less trivial patch. If you have questions about how to implement that I'll be happy to help. >> *** Module::AutoInstall configuration finished. >> WARNING: VERSION takes a string/number not a version reference. >> Please inform the author. >> Writing Makefile for SVK And finally, only now is it shown that this isn't vanilla MakeMaker at all but Module::AutoInstall which is part of Module::Install which breaks the MakeMaker warranty nine ways to Sunday! I have no idea what it might be doing or what you're doing to trigger this code. I still lack an explanation about how to trigger this bug and I'm not going to spend time guessing when you can just attach a tarball with the failing code instead of feeding me a few out-of-context lines at a time.
