On 06/01/2008, Rafael Garcia-Suarez <[EMAIL PROTECTED]> wrote: > On 06/01/2008, Rafael Garcia-Suarez <[EMAIL PROTECTED]> wrote: > > On 23/12/2007, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > > Whoops, missed a revision there. Use this patch instead. > > > > Thanks, applied as #32876. > > Oh, and I needed to patch MM_Unix.pm as follows, to avoid it emitting > the new warning: > > Change 32879 by [EMAIL PROTECTED] on 2008/01/06 18:00:41 > > Don't use grep in scalar context > > Affected files ... > > ... //depot/perl/lib/ExtUtils/MM_Unix.pm#232 edit > > Differences ... > > ==== //depot/perl/lib/ExtUtils/MM_Unix.pm#232 (text) ==== > > @@ -18,7 +18,7 @@ > > use ExtUtils::MakeMaker qw($Verbose neatvalue); > > -$VERSION = '6.42'; > +$VERSION = '6.42_01';
This change is upsetting Test::Builder because apparently EU::MM doesnt do $VERSION=eval $VERSION; like it should when the version is a dev release. Also i count at least seven test files need to be patched to be warning free. . o O ( I really dont see the point of this warning actually. In the core we have seen what, 8 false positives for this warning? For what gain? ) Cheers, yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
