Yes yes yes! Very good suggestion, Christoph. We maybe should also define some rules howto use styles in order to avoid conflicting definitions - not sure, but i think when including css definitions, they overwrite earlier included definitions. So a modules css file has to use the elemtent's/modules's scope, using corresponding selectors.
I'm in favor of this suggestion. Cheers, Michael 2009/8/13 Christoph Baudson <[email protected]>: > Hello, > > I wondered why all modules have to add their CSS files to the body element. > This is not modular. I checked index.php and found that the SQL that queries > the file/css entries from gui_element_vars is restricted to the element > "body". I think that is not sensible. > > I recommend to change this to all non-iframe application elements. My SQL > would read sth like this > > SELECT DISTINCT var_value AS var_value FROM gui_element AS ge, > gui_element_vars AS gevWHERE ge.e_id = gev.fkey_e_id AND ge.fkey_gui_id = > gev.fkey_gui_id AND ge.e_id = gev.fkey_e_id AND ge.e_element <> 'iframe' AND > gev.fkey_gui_id = $1 AND gev.var_type='file/css' > > Then each module could come with its own CSS settings. In the past missing > CSS files have been a major source for errors, mostly because people didn't > add them to body (popup comes to mind). > > Let's discuss if this is a good approach. We could also do this for > text/css. > > Christoph > > -- > ---------------------------------- > > Aufwind durch Wissen! > > Qualifizierte OpenSource-Schulungen > bei der www.foss-academy.eu > > ---------------------------------- > _______________________________________ > > W h e r e G r o u p GmbH & Co. KG > > Siemensstraße 8 > 53121 Bonn > Germany > > Christoph Baudson > Anwendungsentwickler > > Fon: +49 (0)228 / 90 90 38 - 15 > Fax: +49 (0)228 / 90 90 38 - 11 > [email protected] > www.wheregroup.com > Amtsgericht Bonn, HRA 6788 > _______________________________________ > > Komplementärin: > WhereGroup Verwaltungs GmbH > vertreten durch: > Olaf Knopp, Peter Stamm > _______________________________________ > _______________________________________________ > Mapbender_dev mailing list > [email protected] > http://lists.osgeo.org/mailman/listinfo/mapbender_dev > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Aufwind durch Wissen! Qualifizierte Open Source Schulungen bei der http://www.foss-akademie.de/ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ----------------------------------------------------------- Michael Schulz [email protected] in medias res Gesellschaft für Informationstechnologie mbH +++ Bitte beachten Sie unsere neue Adresse und Durchwahl +++ Schwimmbadstraße 2 D-79100 Freiburg i. Br. Tel: +49 (0)761 705798-102 Tel: +49 (0)761 705798-0 Fax: +49 (0)761 705798-09 +++ Bitte beachten Sie unsere neue Adresse und Durchwahl +++ http://www.webgis.de / http://www.zopecms.de -------------------------------------------------------------- Geschäftsführer: Stefan Giese, Dr. Christof Lindenbeck Eingetragen im Handelsregister HRB 5930 beim Amtsgericht Freiburg _______________________________________________ Mapbender_dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/mapbender_dev
