-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Christoph Baudson wrote: > Christoph Baudson wrote: >> Hello list, >> >> is there anyone willing to write unit tests for the GeoJSON to GML >> converter? >> >> Due to a problem in trunk, I added a test case for donut polygons and >> GML2, see [1]. We could easily extend the coverage to all geometry >> types (points, multipoints, lines, multilines, polygons, donut >> polygons (done), multipolygons, donut multipolygons) in both GML2 and >> GML3, we just need data. You could use the standard gui_digitize for >> GML2. >> >> The process is simple: First, add a new test case for each geometry >> type. Then digitize each geometry, and save it to the default >> featuretype (edit_polygons, edit_lines, edit_points). You can get the >> GeoJSON from Firebug. If saving succeeds, get the GML from the logs, >> and validate against it. >> >> If you have any questions, please let me know. It's a fairly easy task >> and you can learn about PHPUnit this way. > > Jonas (intern at WhereGroup) has successfully added these tests to SVN. > I will have to do a code review later on, but the tests are more or less > complete.
The code has been reviewed; all tests seem to be plausible now and pass. Here's the changeset [1]. The bug fixes have also been merged to the 2.6 branch [2]. Christoph [1] http://trac.osgeo.org/mapbender/changeset/7032/trunk [2] http://trac.osgeo.org/mapbender/changeset/7033/trunk > > Thanks to Jonas for his work :-) > > Christoph > > >> >> Christoph >> >> [1] >> http://trac.osgeo.org/mapbender/browser/trunk/mapbender/test/http/classes/Gml2FactoryTest.php >> >> > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkyuEAMACgkQGtMIfbycMX41DwCgj27YkOzxbfUzLEV5hg07Lvjg ySsAn2v8akRHA8L1mZ3A+JhCVvg2ojNY =M+CT -----END PGP SIGNATURE----- _______________________________________________ Mapbender_dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/mapbender_dev
