Changes need to be submitted to the Fusion project (not MapGuide) and preferably attached to the Trac ticket as a patch.
Assuming Windows: Step 1: download and install TortoiseSVN http://tortoisesvn.tigris.org/ Step 2: check out http://svn.osgeo.org/fusion/trunk/ into a local folder Step 3: modify the checked out copy with your changes Step 4: right-click on the top level of your checkout, go to the TortoiseSVN menu, and select Create Patch, which will allow you to save a diff file of your changes. Step 5: if you don't already have one, sign up for an OSGeo ID http://www.osgeo.org/osgeo_userid Step 6: sign into the Fusion track using your OSGeo ID and attach your patch file to the ticket. Make sure the extension you use on your file is .patch so that syntax highlighting works. http://trac.osgeo.org/fusion/ticket/229 Step 7: send an email to the fusion-dev mailing list asking them to review / commit (Nabble link below) http://n2.nabble.com/Fusion-Developers-f2061968.html I don't think I'm missing anything critical here, but let me know if you have any questions. This process should be documented somewhere. I guess it's just assumed knowledge; a common failing :) Jason -----Original Message----- From: GreenMapSanMiguel Sent: Friday, July 17, 2009 9:27 AM Subject: RE: [mapguide-users] MgSelection::AddFeatures locks FeatureSource Fusion 2.1 appears to be leaving feature readers open in both Query and Search as Jason Birch previously documented for Fusion 1.1. I have modified my local versions as follows: Fusion/layer/MapGuide/php/Query.php The feature reader opened on line 140 is re-opened on line 261 under the same name without first being closed. Added '$featureReader->Close();' before line 261. widgets/Search/Search.php The feature reader is only being closed in the exception handling. Added '$features->Close();' after line 227. Unfortunately, making these changes does not fix the problem that I'm having with layers remaining locked after use of setSelection and Search but it does seem like good housekeeping to close the feature readers. I don't know how to formally submit changes. Is there some documentation available? Thanks! Andy _______________________________________________ mapguide-users mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/mapguide-users
