Author: bobby
Date: Thu Apr 19 20:23:47 2012
New Revision: 1328106
URL: http://svn.apache.org/viewvc?rev=1328106&view=rev
Log:
MAPREDUCE-4129. Lots of unneeded counters log messages (Ahmed Radwan via bobby)
Modified:
hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/counters/AbstractCounters.java
Modified: hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt?rev=1328106&r1=1328105&r2=1328106&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt Thu Apr 19
20:23:47 2012
@@ -379,6 +379,9 @@ Release 0.23.3 - UNRELEASED
MAPREDUCE-4165. Committing is misspelled as commiting in task logs
(John Eagles via bobby)
+ MAPREDUCE-4129. Lots of unneeded counters log messages (Ahmed Radwan via
+ bobby)
+
Release 0.23.2 - UNRELEASED
INCOMPATIBLE CHANGES
Modified:
hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/counters/AbstractCounters.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/counters/AbstractCounters.java?rev=1328106&r1=1328105&r2=1328106&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/counters/AbstractCounters.java
(original)
+++
hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/counters/AbstractCounters.java
Thu Apr 19 20:23:47 2012
@@ -201,7 +201,15 @@ public abstract class AbstractCounters<C
* @return the group
*/
public synchronized G getGroup(String groupName) {
- String newGroupName = filterGroupName(groupName);
+
+ // filterGroupName
+ boolean groupNameInLegacyMap = true;
+ String newGroupName = legacyMap.get(groupName);
+ if (newGroupName == null) {
+ groupNameInLegacyMap = false;
+ newGroupName = Limits.filterGroupName(groupName);
+ }
+
boolean isFGroup = isFrameworkGroup(newGroupName);
G group = isFGroup ? fgroups.get(newGroupName) : groups.get(newGroupName);
if (group == null) {
@@ -212,19 +220,14 @@ public abstract class AbstractCounters<C
limits.checkGroups(groups.size() + 1);
groups.put(newGroupName, group);
}
+ if (groupNameInLegacyMap) {
+ LOG.warn("Group " + groupName + " is deprecated. Use " + newGroupName
+ + " instead");
+ }
}
return group;
}
- private String filterGroupName(String oldName) {
- String newName = legacyMap.get(oldName);
- if (newName == null) {
- return Limits.filterGroupName(oldName);
- }
- LOG.warn("Group "+ oldName +" is deprecated. Use "+ newName +" instead");
- return newName;
- }
-
/**
* Returns the total number of counters, by summing the number of counters
* in each group.
