Author: vinodkv
Date: Thu Aug 30 21:04:05 2012
New Revision: 1379148
URL: http://svn.apache.org/viewvc?rev=1379148&view=rev
Log:
MAPREDUCE-4569. Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not
depending on test order. Contributed by Thomas Graves.
svn merge --ignore-ancestry -c 1379146 ../../trunk/
Modified:
hadoop/common/branches/branch-2/hadoop-mapreduce-project/CHANGES.txt
hadoop/common/branches/branch-2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
Modified: hadoop/common/branches/branch-2/hadoop-mapreduce-project/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-mapreduce-project/CHANGES.txt?rev=1379148&r1=1379147&r2=1379148&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-mapreduce-project/CHANGES.txt
(original)
+++ hadoop/common/branches/branch-2/hadoop-mapreduce-project/CHANGES.txt Thu
Aug 30 21:04:05 2012
@@ -429,6 +429,9 @@ Release 0.23.3 - UNRELEASED
MAPREDUCE-4375. Show Configuration Tracability in MR UI (bobby
via tgraves)
+ MAPREDUCE-4569. Fixed TestHsWebServicesJobsQuery to pass on JDK7 by not
+ depending on test order. (Thomas Graves via vinodkv)
+
OPTIMIZATIONS
MAPREDUCE-3850. Avoid redundant calls for tokens in TokenCache (Daryn
Modified:
hadoop/common/branches/branch-2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
URL:
http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java?rev=1379148&r1=1379147&r2=1379148&view=diff
==============================================================================
---
hadoop/common/branches/branch-2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
(original)
+++
hadoop/common/branches/branch-2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
Thu Aug 30 21:04:05 2012
@@ -25,6 +25,7 @@ import static org.mockito.Mockito.when;
import java.io.IOException;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collections;
import java.util.Map;
@@ -217,9 +218,23 @@ public class TestHsWebServicesJobsQuery
@Test
public void testJobsQueryStateNone() throws JSONException, Exception {
WebResource r = resource();
+
+ ArrayList<JobState> JOB_STATES =
+ new ArrayList<JobState>(Arrays.asList(JobState.values()));
+
+ // find a state that isn't in use
+ Map<JobId, Job> jobsMap = appContext.getAllJobs();
+ for (Map.Entry<JobId, Job> entry : jobsMap.entrySet()) {
+ JOB_STATES.remove(entry.getValue().getState());
+ }
+
+ assertTrue("No unused job states", JOB_STATES.size() > 0);
+ JobState notInUse = JOB_STATES.get(0);
+
ClientResponse response = r.path("ws").path("v1").path("history")
- .path("mapreduce").path("jobs").queryParam("state",
JobState.KILL_WAIT.toString())
+ .path("mapreduce").path("jobs").queryParam("state",
notInUse.toString())
.accept(MediaType.APPLICATION_JSON).get(ClientResponse.class);
+
assertEquals(MediaType.APPLICATION_JSON_TYPE, response.getType());
JSONObject json = response.getEntity(JSONObject.class);
assertEquals("incorrect number of elements", 1, json.length());