-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/132/
-----------------------------------------------------------
(Updated 2010-11-30 15:00:19.591764)
Review request for hadoop-mapreduce.
Changes
-------
Removed commented-out code.
ParityBlockInfo is no longer needed since we now use
HarFileSystem.getFileBlockLocations() from MAPREDUCE-1752.
Summary
-------
Currently, FSCK reports files as corrupt even if they can be fixed using parity
blocks. We need a tool that only reports files that are irreparably corrupt
(i.e., files for which too many data or parity blocks belonging to the same
stripe have been lost or corrupted).
This addresses bug MAPREDUCE-2156.
https://issues.apache.org/jira/browse/MAPREDUCE-2156
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/RaidShell.java
1040731
http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestRaidShellFsck.java
PRE-CREATION
Diff: https://reviews.apache.org/r/132/diff
Testing
-------
TestRaidShell
TestRaidFsck
ant test-patch output:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 4 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
Thanks,
Patrick
