----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1091/ -----------------------------------------------------------
(Updated 2011-07-18 23:26:12.317246) Review request for hadoop-mapreduce. Changes ------- -Included a sample text for the JUnit tests to run (about 5MB; it is the complete works of Shakespeare). -Fixed some stream closings so they are enclosed within a try/catch with a finally for the closure. -Moved files from source to test/mapred. Summary ------- Looking to add 3 new examples -- they can be added via the diff attached; some changes to the ExamplesDriver.java might be required however these files do work alone as well. I will also be attaching JUnit tests for these examples. I will post another review request for those. Diffs (updated) ----- http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordStandardDeviation.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/input/shaks12.txt PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordMedian.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordStandardDeviation.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordMean.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/examples/TestWordMedian.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/src/examples/org/apache/hadoop/examples/WordMean.java PRE-CREATION Diff: https://reviews.apache.org/r/1091/diff Testing ------- JUnit tests added -- reduced to 3 tests that all read from an input folder. Thanks, Plamen
