JIRA went down so replying here:

/me facepalms at not seeing that. Sorry.

I have reverted MAPREDUCE-4422 from both branch-2 and trunk, for until
your comments are all addressed.

On Fri, Jul 13, 2012 at 1:26 PM, Arun C Murthy (JIRA) <[email protected]> wrote:
>
>      [ 
> https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
>
> Arun C Murthy reopened MAPREDUCE-4422:
> --------------------------------------
>
>
> Uh, Harsh/Ahmed, I'm confused... the newly added variable 
> DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of 
> adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?
>
> Also, not sure whether this was introduced via MAPREDUCE-3505, but we should 
> use Configuration.getStrings rather than do a 'manual' String.split to parse 
> this out.
>
>> YARN_APPLICATION_CLASSPATH needs a documented default value in 
>> YarnConfiguration
>> --------------------------------------------------------------------------------
>>
>>                 Key: MAPREDUCE-4422
>>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
>>             Project: Hadoop Map/Reduce
>>          Issue Type: Improvement
>>          Components: nodemanager
>>    Affects Versions: 2.0.0-alpha
>>            Reporter: Arun C Murthy
>>            Assignee: Ahmed Radwan
>>             Fix For: 2.0.1-alpha
>>
>>         Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>>
>>
>> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
>> However, we didn't add a default value to YarnConfiguration, as-is the norm.
>> Ran into it while investigating MAPREDUCE-4421.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA 
> administrators: 
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>



-- 
Harsh J

Reply via email to