Thanks Harsh, I'll wait a couple more days and if there are no objections I'll prepare a patch to get rid of them.
Thx On Fri, Feb 8, 2013 at 9:15 PM, Harsh J <[email protected]> wrote: > Hadoop streaming is also tied to recordio as it is today: > https://issues.apache.org/jira/browse/MAPREDUCE-3303, but it can be > removed per Klaas. > > On Sat, Feb 9, 2013 at 6:48 AM, Alejandro Abdelnur <[email protected]> > wrote: > > This seems to be used only in tests in common and in a standalone class > in > > streaming tests. > > > > What is the purpose of these classes as they don't seem to be used in the > > any of the source that ends up in Hadoop? > > > > hadoop-common-project/hadoop-common/src/test/ddl/buffer.jr > > hadoop-common-project/hadoop-common/src/test/ddl/int.jr > > hadoop-common-project/hadoop-common/src/test/ddl/string.jr > > hadoop-common-project/hadoop-common/src/test/ddl/test.jr > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/FromCpp.java > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/RecordBench.java > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/TestBuffer.java > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/TestRecordIO.java > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/TestRecordVersioning.java > > > hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/record/ToCpp.java > > > hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/typedbytes/TestIO.java > > > > > > I've deleted the above classes, cleaned up the common POM (not to compile > > the JR files) and everything compiles fine. > > > > To me all this is dead code, if so, can we nuke them? > > > > Thx > > > > -- > > Alejandro > > > > -- > Harsh J > -- Alejandro
