[
https://issues.apache.org/jira/browse/MAPREDUCE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer resolved MAPREDUCE-344.
----------------------------------------
Resolution: Fixed
Stale.
> Remove dead code block in JobInProgress.completedTask
> ------------------------------------------------------
>
> Key: MAPREDUCE-344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-344
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
>
> Since the taskCommitThread ensures that one and only one task of a given TIP
> is marked as SUCCEEDED, we don't need the code block in
> JobInProgress.completedTask which checks if the TIP is complete and then just
> marks the task as complete:
> {noformat}
> // Sanity check: is the TIP already complete?
> if (tip.isComplete()) {
> // Mark this task as KILLED
> tip.alreadyCompletedTask(taskid);
> // Let the JobTracker cleanup this taskid if the job isn't running
> if (this.status.getRunState() != JobStatus.RUNNING) {
> jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
> }
> return false;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
