Ok Sent from my iPhone
> On May 4, 2016, at 9:51 PM, Allen Wittenauer <a...@apache.org> wrote: > > > When the sub-projects re-merged, maven work was done, whatever, the shell > scripts for MR and YARN were placed (effectively) outside of the normal maven > hierarchy. In order to add unit tests to the shell scripts for these > sub-projects, it means effectively turning hadoop-yarn-project/hadoop-yarn > and hadoop-mapreduce-project into “real” modules so that mvn test works as > expected. Doing so will likely have some surprising consequences, such as > anyone who modifies java code and the shell code in a patch will trigger > _all_ of the unit tests in yarn. > > I think we have four options: > > a) Continue forward turning these into real modules with src directories, etc > and we live with the consequences > > b) Move the related bits into an existing module, making them similar to > HDFS, common, tools > > c) Move the related bits into a new module, using the layout that maven > really really wants > > d) Skip the unit tests; we don’t have them now > > This is clearly more work than what I really wanted to cover in this > branch, but given that there was a specific request to add unit test code for > this functionality, I’m sort of stuck here. > > Thoughts? > --------------------------------------------------------------------- > To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org > ---------------------------------------------------------------------- This message and any attachments are intended only for the use of the addressee and may contain information that is privileged and confidential. If the reader of the message is not the intended recipient or an authorized representative of the intended recipient, you are hereby notified that any dissemination of this communication is strictly prohibited. If you have received this communication in error, notify the sender immediately by return email and delete the message and any attachments from your system. --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org
