+1 (binding)

* Verified all checksums.
* Verified all signatures.
* Built from source, including native code on Linux.
    * mvn clean package -Pnative -Psrc -Drequire.openssl -Drequire.snappy
-Drequire.zstd -DskipTests
* Almost all unit tests passed.
    * mvn clean test -Pnative -Dparallel-tests -Drequire.snappy
-Drequire.zstd -Drequire.openssl -Dsurefire.rerunFailingTestsCount=3
-DtestsThreadCount=8
    * TestBookKeeperHACheckpoints consistently has a few failures.
    * TestCapacitySchedulerNodeLabelUpdate is flaky, intermittently timing
out.

These test failures don't look significant enough to hold up a release, so
I'm still voting +1.

Chris Nauroth


On Sun, May 29, 2022 at 2:35 AM Masatake Iwasaki <
iwasak...@oss.nttdata.co.jp> wrote:

> Thanks for the help, Ayush.
>
> I committed HADOOP-16663/HADOOP-16664 and cherry-picked HADOOP-16985 to
> branch-2.10 (and branch-3.2).
> If I need to cut RC1, I will try cherry-picking them to branch-2.10.2
>
> Masatake Iwasaki
>
>
> On 2022/05/28 5:23, Ayush Saxena wrote:
> > The checksum stuff was addressed in HADOOP-16985, so that filename stuff
> is
> > sorted only post 3.3.x
> > BTW it is a known issue:
> >
> https://issues.apache.org/jira/browse/HADOOP-16494?focusedCommentId=16927236&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16927236
> >
> > Must not be a blocker for us....
> >
> > The RAT check failing with dependency issue. That also should work post
> > 3.3.x because there is no Hadoop-maven-plugin dependency in
> Hadoop-yarn-api
> > module post 3.3.x, HADOOP-16560 removed it.
> > Ref:
> >
> https://github.com/apache/hadoop/pull/1496/files#diff-f5d219eaf211871f9527ae48da59586e7e9958ea7649de74a1393e599caa6dd6L121-R122
> >
> > So, that is why the RAT check passes for 3.3.x+ without the need of this
> > module. Committing HADOOP-16663, should solve this though.(I haven't
> tried
> > though, just by looking at the problem)
> >
> > Good to have patches, but doesn't look like blockers to me. kind of build
> > related stuffs only, nothing bad with our core Hadoop code.
> >
> > -Ayush
> >
> > On Sat, 28 May 2022 at 01:04, Viraj Jasani <vjas...@apache.org> wrote:
> >
> >> +0 (non-binding),
> >>
> >> * Signature/Checksum looks good, though I am not sure where
> >> "target/artifacts" is coming from for the tars, here is the diff (this
> was
> >> the case for 2.10.1 as well but checksum was correct):
> >>
> >> 1c1
> >> < SHA512 (hadoop-2.10.2-site.tar.gz) =
> >>
> >>
> 3055a830003f5012660d92da68a317e15da5b73301c2c73cf618e724c67b7d830551b16928e0c28c10b66f04567e4b6f0b564647015bacc4677e232c0011537f
> >> ---
> >>> SHA512 (target/artifacts/hadoop-2.10.2-site.tar.gz) =
> >>
> >>
> 3055a830003f5012660d92da68a317e15da5b73301c2c73cf618e724c67b7d830551b16928e0c28c10b66f04567e4b6f0b564647015bacc4677e232c0011537f
> >> 1c1
> >> < SHA512 (hadoop-2.10.2-src.tar.gz) =
> >>
> >>
> 483b6a4efd44234153e21ffb63a9f551530a1627f983a8837c655ce1b8ef13486d7178a7917ed3f35525c338e7df9b23404f4a1b0db186c49880448988b88600
> >> ---
> >>> SHA512 (target/artifacts/hadoop-2.10.2-src.tar.gz) =
> >>
> >>
> 483b6a4efd44234153e21ffb63a9f551530a1627f983a8837c655ce1b8ef13486d7178a7917ed3f35525c338e7df9b23404f4a1b0db186c49880448988b88600
> >> 1c1
> >> < SHA512 (hadoop-2.10.2.tar.gz) =
> >>
> >>
> 13e95907073d815e3f86cdcc24193bb5eec0374239c79151923561e863326988c7f32a05fb7a1e5bc962728deb417f546364c2149541d6234221b00459154576
> >> ---
> >>> SHA512 (target/artifacts/hadoop-2.10.2.tar.gz) =
> >>
> >>
> 13e95907073d815e3f86cdcc24193bb5eec0374239c79151923561e863326988c7f32a05fb7a1e5bc962728deb417f546364c2149541d6234221b00459154576
> >>
> >> However, checksums are correct.
> >>
> >> * Builds from source look good
> >>   - mvn clean install  -DskipTests
> >>   - mvn clean package  -Pdist -DskipTests -Dtar
> -Dmaven.javadoc.skip=true
> >>
> >> * Rat check, if run before building from source locally, fails with
> error:
> >>
> >> [ERROR] Plugin org.apache.hadoop:hadoop-maven-plugins:2.10.2 or one of
> its
> >> dependencies could not be resolved: Could not find artifact
> >> org.apache.hadoop:hadoop-maven-plugins:jar:2.10.2 in central (
> >> https://repo.maven.apache.org/maven2) -> [Help 1]
> >> [ERROR]
> >>
> >> However, once we build locally, rat check passes (because
> >> hadoop-maven-plugins 2.10.2 would be present in local .m2).
> >> Also, hadoop-maven-plugins:2.10.2 is available here
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachehadoop-1350/org/apache/hadoop/hadoop-maven-plugins/2.10.2/
> >>
> >> * Ran sample HDFS and MapReduce commands, look good.
> >>
> >> Until we release Hadoop artifacts, hadoop-maven-plugins for that release
> >> would not be present in the central maven repository, hence I am still
> >> wondering how rat check failed only for this RC and not for any of
> previous
> >> release RCs. hadoop-vote.sh always runs rat check before building from
> >> source locally.
> >>
> >>
> >> On Tue, May 24, 2022 at 7:41 PM Masatake Iwasaki <
> >> iwasak...@oss.nttdata.co.jp> wrote:
> >>
> >>> Hi all,
> >>>
> >>> Here's Hadoop 2.10.2 release candidate #0:
> >>>
> >>> The RC is available at:
> >>>     https://home.apache.org/~iwasakims/hadoop-2.10.2-RC0/
> >>>
> >>> The RC tag is at:
> >>>     https://github.com/apache/hadoop/releases/tag/release-2.10.2-RC0
> >>>
> >>> The Maven artifacts are staged at:
> >>>
> >> https://repository.apache.org/content/repositories/orgapachehadoop-1350
> >>>
> >>> You can find my public key at:
> >>>     https://downloads.apache.org/hadoop/common/KEYS
> >>>
> >>> Please evaluate the RC and vote.
> >>> The vote will be open for (at least) 5 days.
> >>>
> >>> Thanks,
> >>> Masatake Iwasaki
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
> >>> For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
> >>>
> >>>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
> For additional commands, e-mail: common-dev-h...@hadoop.apache.org
>
>

Reply via email to