[ 
https://issues.apache.org/jira/browse/MAPREDUCE-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726341#action_12726341
 ] 

Hemanth Yamijala commented on MAPREDUCE-522:
--------------------------------------------

It would be good to determine a goal for this test case. I think many of the 
tests mentioned above (queue capacity expansion, new tasks starting as a 
previous wave finishes), are all adequately tested by the testcases in 
TestCapacityScheduler. 

I think the original intent of this test case was primarily to define a smoke 
test that integrates the capacity scheduler with the M/R framework - 
particularly jobtracker - and make sure that submitted jobs get scheduled and 
run. Whether the right scheduling decisions are taken is testing the capacity 
scheduler, and that is already done (or can be done if missing) in 
TestCapacityScheduler.

So, what if we simply have one test case that runs small jobs requiring less, 
equal and more of the capacity of 2 queues (50%) each and just make sure they 
all run and complete successfully ? Would that be simple enough to work while 
retaining the original goal ?



> Rewrite TestQueueCapacities to make it simpler and avoid timeout errors
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-522
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-522
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Hemanth Yamijala
>
> We have seen TestQueueCapacities fail periodically and there have been a 
> couple of times fixes partially fixed the problem, the most recent instance 
> being HADOOP-5869. I found another instance of failure, while running tests 
> locally while testing a different patch. This was a different symptom from 
> the ones we've seen before. The core problem is that the test is too complex 
> and relies on too many things working correctly to be useful. It would make 
> sense to revisit the purpose of the test and see if a simpler model can serve 
> it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to