[ 
https://issues.apache.org/jira/browse/MAPREDUCE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732404#action_12732404
 ] 

rahul k singh commented on MAPREDUCE-766:
-----------------------------------------

Looking good:
 minor comments :

1.In ClusterStatus.

   1.BlackListedInfo is a package private class make it public.

   2.all the member variables need to private.

   3."public Collection<String> getBlacklistedTrackerNames" need to be changed 
, it currently passes hostname , it should be
    passing the tracker names.

   ClusterStatus constructor "ClusterStatus(
    Collection<String> activeTrackers,
    Collection<BlackListInfo> blacklistedTrackers, long ttExpiryInterval,
    int maps, int reduces, int maxMaps, int maxReduces,
    JobTracker.State state, int numDecommissionNodes) " 

    is crossing 80 chars

> Enhance -list-blacklisted-trackers to display host name, blacklisted reason 
> and blacklist report.
> -------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-766
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-766
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: mapreduce-766-1.patch, mapreduce-766-2.patch
>
>
> Currently, the -list-blacklisted-trackers in the mapred job option list only 
> tracker name. We should enhance it to display as hostname, reason for 
> blacklisting and blacklist report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to