[ 
https://issues.apache.org/jira/browse/MAPREDUCE-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734249#action_12734249
 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-716:
--------------------------------------------------

Since test-patch is broken (see HADOOP-6124), the patch committed introduced 
some javac warnings without being detected.
{noformat}
    [javac] 
d:\...@sze\hadoop\mapreduce\m1\src\java\org\apache\hadoop\mapreduce\lib\db\dbinputformat.java:184:
 warning: [unchecked] unchecked conversion
    [javac] found   : java.lang.Class
    [javac] required: java.lang.Class<T>
    [javac]         return new OracleDBRecordReader<T>(split, inputClass,
    [javac]                                                   ^
    [javac] 
d:\...@sze\hadoop\mapreduce\m1\src\java\org\apache\hadoop\mapreduce\lib\db\dbinputformat.java:188:
 warning: [unchecked] unchecked conversion
    [javac] found   : java.lang.Class
    [javac] required: java.lang.Class<T>
    [javac]         return new MySQLDBRecordReader<T>(split, inputClass,
    [javac]                                                  ^
    [javac] 
d:\...@sze\hadoop\mapreduce\m1\src\java\org\apache\hadoop\mapreduce\lib\db\dbinputformat.java:192:
 warning: [unchecked] unchecked conversion
    [javac] found   : java.lang.Class
    [javac] required: java.lang.Class<T>
    [javac]         return new DBRecordReader<T>(split, inputClass,
    [javac]                                             ^
{noformat}

> org.apache.hadoop.mapred.lib.db.DBInputformat not working with oracle
> ---------------------------------------------------------------------
>
>                 Key: MAPREDUCE-716
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-716
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>         Environment: Java 1.6, HAdoop0.19.0, Linux..Oracle, 
>            Reporter: evanand
>            Assignee: Aaron Kimball
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5482.20-branch.patch, HADOOP-5482.patch, 
> HADOOP-5482.trunk.patch, MAPREDUCE-716.2.branch20.patch, 
> MAPREDUCE-716.2.trunk.patch, MAPREDUCE-716.3.trunk.patch, 
> MAPREDUCE-716.4.branch20.patch, MAPREDUCE-716.4.trunk.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> org.apache.hadoop.mapred.lib.db.DBInputformat not working with oracle.
> The out of the box implementation of the Hadoop is working properly with 
> mysql/hsqldb, but NOT with oracle.
> Reason is DBInputformat is implemented with mysql/hsqldb specific query 
> constructs like "LIMIT", "OFFSET".
> FIX:
> building a database provider specific logic based on the database 
> providername (which we can get using connection).
> I HAVE ALREADY IMPLEMENTED IT FOR ORACLE...READY TO CHECK_IN CODE

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to