[
https://issues.apache.org/jira/browse/MAPREDUCE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jothi Padmanabhan updated MAPREDUCE-375:
----------------------------------------
Status: Open (was: Patch Available)
Looks good. A few comments
# Could you see if you can have the mapred.FileSplit class extend
mapreduce.FileSplit so that you could refactor NLineInputFormat implementation
to avoid code duplication.
# The changes to TextInputFormat and SequenceFileInputFormat to check for
compression can possibly be reverted. I feel the old code is both more readable
and faster -- they avoid method calls if the compression is not turned on.
> Change org.apache.hadoop.mapred.lib.NLineInputFormat and
> org.apache.hadoop.mapred.MapFileOutputFormat to use new api.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-375
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-375
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-375.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
