[ 
https://issues.apache.org/jira/browse/MAPREDUCE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743132#action_12743132
 ] 

Sreekanth Ramakrishnan commented on MAPREDUCE-478:
--------------------------------------------------

The changes look fine but there is an extra line in the diff:
{noformat}
diff --git lib/hadoop-core-0.21.0-dev.jar lib/hadoop-core-0.21.0-dev.jar
index 3c58181..bdd5115 100644
Binary files lib/hadoop-core-0.21.0-dev.jar and lib/hadoop-core-0.21.0-dev.jar 
differ
{noformat}


This should be probably the change for {{Shell.getUlimitMemoryCommand(long)}}. 

Apart from this minor nit +1 for the patch.

> separate jvm param for mapper and reducer
> -----------------------------------------
>
>                 Key: MAPREDUCE-478
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-478
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Koji Noguchi
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5684_0_20090420.patch, 
> MAPREDUCE-478_0_20090804.patch, MAPREDUCE-478_0_20090804_yhadoop20.patch, 
> MAPREDUCE-478_1_20090806.patch, MAPREDUCE-478_1_20090806_yhadoop20.patch, 
> MAPREDUCE-478_2_20090813.patch, MAPREDUCE-478_2_20090813_yhadoop.patch
>
>
> Memory footprint of mapper and reducer can differ. 
> It would be nice if we can pass different jvm param (mapred.child.java.opts) 
> for mappers and reducers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to