[ 
https://issues.apache.org/jira/browse/MAPREDUCE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756478#action_12756478
 ] 

Tom White commented on MAPREDUCE-777:
-------------------------------------

More comments, mainly naming:

* There are occurrences of both "blacklist" and "blackList" in the public API 
(e.g. TaskTrackerInfo#getReasonForBlackList() and getBlacklistReport()). Either 
is correct since the word may be spelled as "blacklist" or "black list", but we 
need to be consistent throughout. 
* Cluster#getFs() would be better as getFileSystem() (particularly with the 
debate in HADOOP-6223). Also it would be good to have javadoc describing the 
fact it is returning the file system where job-specific files are placed.
* JobStatus#{setup,map,reduce,cleanup}Progress() would be better as getters to 
be consistent with the rest of the class.
* TaskCompletionEvent#getTaskAttemptID() should be getTaskAttemptId() to be 
consistent with getEventId().
* TaskCompletionEvent#setTaskID() should be setTaskAttemptId().
* TaskReport's method names should be made consistent with this convention too.

> A method for finding and tracking jobs from the new API
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-777
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-777
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: client
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>         Attachments: m-777.patch, patch-777-1.txt, patch-777-10.txt, 
> patch-777-11.txt, patch-777-12.txt, patch-777-13.txt, patch-777-2.txt, 
> patch-777-3.txt, patch-777-4.txt, patch-777-5.txt, patch-777-6.txt, 
> patch-777-7.txt, patch-777-8.txt, patch-777-9.txt, patch-777.txt
>
>
> We need to create a replacement interface for the JobClient API in the new 
> interface. In particular, the user needs to be able to query and track jobs 
> that were launched by other processes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to