[
https://issues.apache.org/jira/browse/MAPREDUCE-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767868#action_12767868
]
Hemanth Yamijala commented on MAPREDUCE-1105:
---------------------------------------------
Regarding the 20 patch:
- Typo maxiumCapacity in the code that distributes capacities to queues without
configured capacity.
- This patch is missing the optimizing check in assignTasks for a queue being
over capacity.
- In the Forrest documentation, max capacity is being referred to as
maximum-capacity sometimes and max capacity sometimes. They should be
consistently called maximum-capacity.
- In checkMultipleAssignment, if the returned tasks is null or empty and some
tasks are expected, we are failing the test, but also returning tasks. The
return is a no-op and can be removed.
Also in both the trunk and 20 patch, I think it would be useful to add a test
that ensures that if undistributed capacity results in maxCapacity lesser than
configured capacity, scheduler fails on startup.
> CapacityScheduler: It should be possible to set queue hard-limit beyond it's
> actual capacity
> --------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1105
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1105
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.21.0
> Reporter: Arun C Murthy
> Assignee: rahul k singh
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPRED-1105-21-1.patch, MAPRED-1105-21-2.patch,
> MAPREDUCE-1105-version20-2.patch, MAPREDUCE-1105-version20.patch.txt
>
>
> Currently the CS caps a queue's capacity to it's actual capacity if a
> hard-limit is specified to be greater than it's actual capacity. We should
> allow the queue to go upto the hard-limit if specified.
> Also, I propose we change the hard-limit unit to be percentage rather than
> #slots.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
