[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768087#action_12768087
 ] 

Jothi Padmanabhan commented on MAPREDUCE-1103:
----------------------------------------------

Few points:

# Weighted methods could be removed from JobTrackerInstrumentation and 
JTMetricsInst
# JTMetricsInst.setMapSlots should also be synchronized
# Should we rename addBlacklistedTracker to addBlackListedTrackers, to be 
consistent with the other method names. Similarly for decBlackListedTracker, 
addTracker, decTracker
# There are some if else statements without the braces. I think we follow the 
style convention of having braces for if-else even if they are one line 
statements

> Additional JobTracker metrics
> -----------------------------
>
>                 Key: MAPREDUCE-1103
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1103
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobtracker
>    Affects Versions: 0.21.0
>            Reporter: Arun C Murthy
>            Assignee: Sharad Agarwal
>             Fix For: 0.21.0
>
>         Attachments: 1103.patch, 1103.patch, 1103_v1.patch, 1103_v2.patch, 
> 1103_v3.patch
>
>
> It would be useful for tracking the following additional JobTracker metrics:
> running{map|reduce}tasks
> busy{map|reduce}slots
> reserved{map|reduce}slots

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to