[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768712#action_12768712
 ] 

Hemanth Yamijala commented on MAPREDUCE-1048:
---------------------------------------------

This looks fine. I have a few minor comments:

- It is confusing that incrementReservations can decrement also. I think its 
better to split the calls into two.
- ClusterMetrics javadoc needs to be updated with total number of job 
submissions.
- In the javadoc of ClientProtocol for version 29, please also include total 
job submissions. I think we also try and include the JIRA which made the change 
in the comment.
- TestClusterStatus can also have a check with a TT coming back twice, so that 
we can cover that the oldStatus is also used to decrement old slot counts 
correctly.
- Similarly, we can also have a check with re-reservation of slots

> Show total slot usage in cluster summary on jobtracker webui
> ------------------------------------------------------------
>
>                 Key: MAPREDUCE-1048
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1048
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobtracker
>    Affects Versions: 0.20.1
>            Reporter: Amar Kamat
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>
>         Attachments: mapred-1048-v1.0.patch, mapred-1048-v1.1.patch, 
> patch-1048-0.20.txt, patch-1048-1.txt, patch-1048-2.txt, patch-1048-3.txt, 
> patch-1048-4.txt, patch-1048-5.txt, patch-1048-6.txt, patch-1048-ydist.txt, 
> patch-1048.txt
>
>
> With High-Ram jobs coming into the picture, its important to also show the 
> slot usage in cluster summary since total-running-maps < 
> total-slots-occupied. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to