[
https://issues.apache.org/jira/browse/MAPREDUCE-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773701#action_12773701
]
Devaraj Das commented on MAPREDUCE-1026:
----------------------------------------
Looked at the patch some more. Few more comments:
1) The tasktracker needs to maintain a mapping from JobIDs to job-tokens
2) The call to localizeJobTokenFile should be done before the call to
taskController.initializeJob(context) in the TaskTracker.localizeJob method.
Could the localizeJobTokenFile be called within TaskTracker.localizeJobFiles
3) Minor: for the request/response HTTP headers, make the first character upper
case
4) HMacUtil could override the equals method and put in logic for comapring two
HMacUtil objects, instead of defining verifyHash.
5) The Comp class in StoreKeys.java seems to be unused. StoreKeys could be
Writable (as opposed to having to define load/store methods)
For the case where a reduce task fails due to the TaskTracker(s) not being
authentic, we probably need care. Two things might happen - the JobTracker
might get enough notifications from other reduces in the system, and it might
just decide to re-execute the map. The other situation is what is bothering me
- the reduce task would kill itself after a certain threshold number of trials.
This would be bad. IIRC it is not predictable which one could happen first.
> Shuffle should be secure
> ------------------------
>
> Key: MAPREDUCE-1026
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1026
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: security
> Reporter: Owen O'Malley
> Assignee: Boris Shkolnik
> Attachments: MAPREDUCE-1026.patch, MAPREDUCE-1026.patch
>
>
> Since the user's data is available via http from the TaskTrackers, we should
> require a job-specific secret to access it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
