[
https://issues.apache.org/jira/browse/MAPREDUCE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782106#action_12782106
]
Matei Zaharia commented on MAPREDUCE-698:
-----------------------------------------
The patch mostly looks good to me, but I have a few comments:
* There seem to be some extra newlines added in FairScheduler.java. You might
want to just svn revert it.
* What is the purpose of the changes to build-contrib.xml? Are they just
something you copied in from another build.xml file?
* In the unit test, it would be good to submit the jobs first (with an
advanceTime between them) before doing any checkAssignment's, so that both jobs
are initially available. Note that the scheduler will probably alternate
between assigning tasks from the two jobs in this case, but it should still not
let job 1 go over its max share.
* In the web UI, can you call the new "Max" column "Max Share" instead, so it
is more consistent with the other column names?
* You can simplify Pool.numRunningTasks(TaskType type) to just return
getSchedulable(type).getRunningTasks(). It might also be good to rename the
method to getRunningTasks instead of nunRunningTasks so that it's more
consistent with the rest of the code.
* Instead of making PoolSchedulable.getDemand() return maxTasks if demand >
maxTasks, it would be better to change PoolSchedulable.updateDemand() to cap
the demand at the end of the method, so that getDemand() just returns demand.
Otherwise, it will be a little confusing to have a variable called demand in
PoolSchedulable whose value is not the same as that returned by getDemand().
> Per-pool task limits for the fair scheduler
> -------------------------------------------
>
> Key: MAPREDUCE-698
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-698
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: contrib/fair-share
> Reporter: Matei Zaharia
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-698-prelim.patch, mapreduce-698-trunk.patch,
> mapreduce-698-trunk.patch
>
>
> The fair scheduler could use a way to cap the share of a given pool similar
> to MAPREDUCE-532.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
