[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated MAPREDUCE-1155:
-----------------------------------

    Attachment: mapreduce-1155.txt

This patch cleans up a bunch of the streaming test code. Primary changes:
 - Got rid of a bunch of instances where exceptions were just printed and 
didn't fail the tests.
 - Fixed StreamJob so that IllegalArgumentExceptions are only swallowed during 
the argument parsing, and not when they come from inside MR. (this is the only 
change to non-test code)
 - Fixed a bunch of instances where a failTrace() method had been copy pasted 
and used in exception catch blocks. This is unnecessary in tests - simply 
letting it bubble up to the test harness is more idiomatic.
 - Fixed a bug where TestMultipleArchivefiles was actually failing the job

These tests could do with a whole lot more cleanup work, but this is a good 
start and at least makes them fail properly when there are problems.

> Streaming tests swallow exceptions
> ----------------------------------
>
>                 Key: MAPREDUCE-1155
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1155
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-1155.txt
>
>
> Many of the streaming tests (including TestMultipleArchiveFiles) catch 
> exceptions and print their stack trace rather than failing the job. This 
> means that tests do not fail even when the job fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to