[
https://issues.apache.org/jira/browse/MAPREDUCE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786077#action_12786077
]
Tom White commented on MAPREDUCE-967:
-------------------------------------
+1 This looks good to me.
bq. One question for reviewer: the constant for the new configuration key is in
JobContext, whereas the default is in JobConf. I was following some other
examples from the code, but it seems a little bit messy here. Where are the
right places to add new configuration parameters that work in both APIs?
The key should certainly go in JobContext, but where the default is located is
less clear. Defaults tend to be defined in the class that they are used, which
is JobConf in this case. However, JobConf is deprecated and will disappear,
although it may still be used by the implementation (i.e. not be a part of the
public API), in which case what you have done is fine.
> TaskTracker does not need to fully unjar job jars
> -------------------------------------------------
>
> Key: MAPREDUCE-967
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-967
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: mapreduce-967-branch-0.20.txt, mapreduce-967.txt,
> mapreduce-967.txt, mapreduce-967.txt
>
>
> In practice we have seen some users submitting job jars that consist of
> 10,000+ classes. Unpacking these jars into mapred.local.dir and then cleaning
> up after them has a significant cost (both in wall clock and in unnecessary
> heavy disk utilization). This cost can be easily avoided
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
