[
https://issues.apache.org/jira/browse/MAPREDUCE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787407#action_12787407
]
Hemanth Yamijala commented on MAPREDUCE-896:
--------------------------------------------
This is getting close. I have a few minor comments:
- get_task_dir_path does not use mapred_local_dir. It can be removed.
- We should also be calling check_tt_root before we start the operation of
cleanup.
- Documentation of PathDeletionContext and its subclasses would be nice. You
can also document methods like enablePathForDeletion.
- TaskTracker.localFs can be private and given by an accessor instead of being
package private and exposed.
- buildPathDeletionContexts and buildTaskControllerPathDeletionContexts can be
private.
- buildPathDeletionContexts is checking for paths being null in one place, but
not everywhere. For e.g. for (Path p : paths) will throw an NPE if paths is
null. I think it is not expected to be null, no ? In which case, we shouldn't
be checking for it.
- I would suggest instead of sending multiple parameters related to Task to
TaskControllerPathDeletionContext, we can send the Task itself. Also, I would
suggest using JobID instead of the value as string.
Other than these, the other changes I verified seem fine.
> Users can set non-writable permissions on temporary files for TT and can
> abuse disk usage.
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-896
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-896
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: MR-896.patch, MR-896.v1.patch, y896.v1.patch,
> y896.v2.patch
>
>
> As of now, irrespective of the TaskController in use, TT itself does a full
> delete on local files created by itself or job tasks. This step, depending
> upon TT's umask and the permissions set by files by the user, for e.g in
> job-work/task-work or child.tmp directories, may or may not go through
> successful completion fully. Thus is left an opportunity for abusing disk
> space usage either accidentally or intentionally by TT/users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
