[
https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787412#action_12787412
]
rahul k singh commented on MAPREDUCE-1067:
------------------------------------------
Queue.java
1. if(state == null) should be done first .
In the same method setState ,
replace the exception message with this :
"is a container queue , its state always running and cannot be reset."
2. children.add(child);
if (QueueState.STOPPED.equals(this.state)) {
throw new IllegalStateException(this.name +
" is a container queue and cannot be in STOPPED state.");
}
In the above scenario , the if check should be before we add children.I
think it should be before
children == null check , first statement in the method.
The message above should be adding child to a queue with state as stopped.
Also mention in comments that this check is not required if Queue object is
built from the XML , this indescrepency
might happen if this Queue is directly built.
> Default state of queues is undefined when unspecified
> -----------------------------------------------------
>
> Key: MAPREDUCE-1067
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.21.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch,
> MAPREDUCE-1067-3.patch
>
>
> Currently, if the state of a queue is not specified, it is being set to
> "undefined" state instead of running state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
