[
https://issues.apache.org/jira/browse/MAPREDUCE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790855#action_12790855
]
Allen Wittenauer commented on MAPREDUCE-1166:
---------------------------------------------
I don't remember if I forced -xc99 or not. I suspect I didn't or I didn't use
-xc99=all. If I get a chance I'll try it again. Although it'd be great to
avoid C99 to give us greater compatibility. Given other issues (__func__), it
is probably unavoidable though.
> SerialUtils.cc: dynamic allocation of arrays based on runtime variable is not
> portable
> --------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1166
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1166
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: MAPREREDUCE-1166.patch
>
>
> In SerialUtils.cc, the following code appears:
> int len;
> if (b < -120) {
> negative = true;
> len = -120 - b;
> } else {
> negative = false;
> len = -112 - b;
> }
> uint8_t barr[len];
> as far as I'm aware, this is not legal in ANSI C and will be rejected by ANSI
> compliant compilers. Instead, this should be malloc()'d based upon the size
> of len and free()'d later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
