[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792918#action_12792918
 ] 

Devaraj Das commented on MAPREDUCE-1250:
----------------------------------------

This is looking good except for one spurious comment "// storage of the job 
token secret" in Task.java, and a white line change in TaskTracker.java.
Regarding sending the token with the task object or not, in the future 
(HADOOP-6325), there would optionally be a credential cache that is passed to 
the JobTracker during job submission. This cache has to be persisted to support 
job recovery. I am thinking that we could add the JobTracker generated JobToken 
to the same file. The current approach in the patch is in line with that..

> Refactor job token to use a common token interface
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1250
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1250
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: m1250-09.patch, m1250-12.patch
>
>
> The idea is to use a common token interface for both job token and delegation 
> token (HADOOP-6373) so that the RPC layer that uses them don't have to 
> differentiate them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to