[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797400#action_12797400
 ] 

Scott Chen commented on MAPREDUCE-1302:
---------------------------------------

+1 to the final patch.
I only have a minor comment. Can we change #getRelativePathName() to 
#isInVolume() instead? Just return true if the absoluteFileName is in the 
volume. It is actually how this function is used right now. This is not 
necessary. Just to make it more clear.

> TrackerDistributedCacheManager can delete file asynchronously
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-1302
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1302
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: tasktracker
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: MAPREDUCE-1302.0.patch, MAPREDUCE-1302.1.patch, 
> MAPREDUCE-1302.2.patch, MAPREDUCE-1302.3.patch, MAPREDUCE-1302.4.patch
>
>
> With the help of AsyncDiskService from MAPREDUCE-1213, we should be able to 
> delete files from distributed cache asynchronously.
> That will help make task initialization faster, because task initialization 
> calls the code that localizes files into the cache and may delete some other 
> files.
> The deletion can slow down the task initialization speed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to