[ 
https://issues.apache.org/jira/browse/MAPREDUCE-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800267#action_12800267
 ] 

Doug Cutting commented on MAPREDUCE-815:
----------------------------------------

This looks great!  A few nits:
 - in javadoc comments, use "@deprecated use #foo()"  to link to the new 
implementation
 - AvroSeekableStream is likely to be reused by other applications that use 
Avro with HDFS.  it might be named AvroFSInput.  it might better belong in 
common than in mapreduce.
 - why use LongWritable?  Could we instead use java.lang.Long?  Or perhaps just 
null for these values?  Does anyone ever make use of the position?  If not, 
let's use null.  If we can avoid a dependency on Writable here that'd be good.  
or does this provide some important compatibility?
 - i don't think SYNC_DISTANCE is needed: DataFileWriter syncs automatically 
every 100k or so.


> Add AvroInputFormat and AvroOutputFormat so that hadoop can use Avro 
> Serialization
> ----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-815
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-815
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: Ravi Gummadi
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-815.patch
>
>
> MapReduce needs AvroInputFormat similar to other InputFormats like 
> TextInputFormat to be able to use avro serialization in hadoop. Similarly 
> AvroOutputFormat is needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to