[
https://issues.apache.org/jira/browse/MAPREDUCE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828979#action_12828979
]
Amar Kamat commented on MAPREDUCE-1358:
---------------------------------------
The reason why I asked for separate testcases for Utils.OutputFilesFilter and
Utils.OutputLogFilter is that there is an implicit assumption that
OutputFilesFilter extends OutputLogFilter. Both the classes are free to change
their implementation of _accept(Path)_ hence we need testcases for both. I
agree with Todd that it looks redundant as of now but will safeguard us from
future mistakes. I had an offline discussion with Todd and he agreed with me on
adding separate testcases for both the utilities.
> Utils.OutputLogFilter incorrectly filters for _logs
> ---------------------------------------------------
>
> Key: MAPREDUCE-1358
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1358
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: mapreduce-1358.txt, mapreduce-1358.txt
>
>
> OutputLogFilter checks if the path contains _logs. This would incorrectly
> filter out all contents of a directory called server_logs, for example.
> Instead it should check for a path component exactly equal to _logs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
