[
https://issues.apache.org/jira/browse/MAPREDUCE-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834078#action_12834078
]
Amareshwari Sriramadasu commented on MAPREDUCE-1354:
----------------------------------------------------
Some comments on the patch:
1. JobInProgress constructor calls methods like
JobTracker.getSystemDirectoryForJob(). This method is called with JobTracker
lock sometimes, JobTracker lock followed by JobInProgress lock sometimes and
without any lock in this case. I think this should not effect any, but we
should verify all the locking orders for all the back calls from JobInProgress
constructor to JobTracker.
2. Unused import for org.apache.tools.ant.taskdefs.condition.HasMethod in
JobInProgress
3. Variable JobTracker.EMPTY_TASK_DIAGNOSTICS is not used anywhere.
> Refactor JobTracker.submitJob to not lock the JobTracker during the HDFS
> accesses
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1354
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1354
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Devaraj Das
> Assignee: Arun C Murthy
> Priority: Critical
> Attachments: MAPREDUCE-1354_yhadoop20.patch,
> MAPREDUCE-1354_yhadoop20.patch, MAPREDUCE-1354_yhadoop20.patch,
> MAPREDUCE-1354_yhadoop20.patch, MAPREDUCE-1354_yhadoop20.patch
>
>
> It'd be nice to have the JobTracker object not be locked while accessing the
> HDFS for reading the jobconf file and while writing the jobinfo file in the
> submitJob method. We should see if we can avoid taking the lock altogether.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
