[
https://issues.apache.org/jira/browse/MAPREDUCE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839558#action_12839558
]
Amareshwari Sriramadasu commented on MAPREDUCE-1522:
----------------------------------------------------
Looked at the patch for trunk.
Some comments:
1. The method Path.makeQualified(FileSystem) is deprecated. Can you change the
call to something like inputPath.getFileSystem(conf).makeQualified(inputPath)?
2. In the testcase, can you change the calls conf.get(mapred.input.dir) to
FileInputFormat.getInputPaths(job).
> FileInputFormat may change the file system of an input path
> -----------------------------------------------------------
>
> Key: MAPREDUCE-1522
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1522
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: m1522_20100224.patch, m1522_20100224_0.20.patch,
> m1552_20100223_0.20.patch
>
>
> org.apache.hadoop.mapreduce.lib.input.FileInputFormat.addInputPath(Job job,
> Path path) uses the default FileSystem but not the FileSystem specified in
> the path.
> {code}
> //org.apache.hadoop.mapreduce.lib.input.FileInputFormat
> public static void addInputPath(Job job,
> Path path) throws IOException {
> Configuration conf = job.getConfiguration();
> FileSystem fs = FileSystem.get(conf);
> path = path.makeQualified(fs); // the original FileSystem is lost.
> ...
> }
> {code}
> There is a similar problem in FileInputFormat.setInputPaths(..).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
